[#10341] - Try to log errors that hit the global exception handler
- Fixed in Code Base
- 3 Oct 2016
- Medium
- Build: staging
- # 10341
- Diff
- mbabker:Error-Logging
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
This will try to write an error message about the uncaught Throwable triggering the error page to a logger registered for the error category while taking measures to keep the act of logging from triggering a fatal error.
Testing Instructions
Set up a logger for the error category (the debug plugin should help with this), trigger the error page, and ensure the error gets logged.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Libraries |
Happy to test this @mbabker but I need a little more guidance
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10341.
Turn on debug mode and make sure the plugin is logging everything and trigger the error page. The data from the Exception should be logged under the "error" category.
The error page in the front-end or admin?
It's not dependent on either application. All error page handling goes through this method.
Can you rebase this and I'll give it a test
Done
... no?
will test tonight
@mbabker can you confirm that this is a correct error:
2016-10-03T15:16:05+00:00 CRITICAL 37.201.171.40 error Uncaught Throwable of type JException thrown. Stack trace: #0 JRoot/libraries/legacy/error/error.php(277): JError::raise(1, 404, 'Category not fo...', NULL, true)
#1 JRoot/libraries/legacy/view/category.php(125): JError::raiseError(404, 'Category not fo...')
#2 JRoot/components/com_content/views/category/view.html.php(72): JViewCategory->commonCategoryDisplay()
#3 JRoot/libraries/legacy/controller/legacy.php(664): ContentViewCategory->display()
#4 JRoot/components/com_content/controller.php(113): JControllerLegacy->display(true, Array)
#5 JRoot/libraries/legacy/controller/legacy.php(702): ContentController->display()
#6 JRoot/components/com_content/content.php(38): JControllerLegacy->execute('')
#7 JRoot/libraries/cms/component/helper.php(405): require_once('/www/htdocs/w00...')
#8 JRoot/libraries/cms/component/helper.php(380): JComponentHelper::executeComponent('/www/htdocs/w00...')
#9 JRoot/libraries/cms/application/site.php(191): JComponentHelper::renderComponent('com_content')
#10 JRoot/libraries/cms/application/site.php(230): JApplicationSite->dispatch()
#11 JRoot/libraries/cms/application/cms.php(261): JApplicationSite->doExecute()
#12 JRoot/index.php(49): JApplicationCms->execute()
#13 {main}
If i produce a 404?
Looks right to me; it's logging that an exception went uncaught to the global handler and the stack trace of the exception with priority "CRITICAL".
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10341.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10341.
| Status | Pending | ⇒ | Ready to Commit |
RTC cc: @rdeutz
Thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10341.
| Labels |
Added:
?
|
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-10-03 19:23:19 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
Removed RTC label
| Labels |
Removed:
?
|
||
Could use some tests here, having this would make debugging issues a little easier as anything triggering the error page would write a log statement with a stack trace if a logger is configured...