? Success

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
30 Apr 2016

Summary of Changes

Use the showon functionality now available in forms to simplify/reduce the options displayed in article options

Testing Instructions

This is only a cosmetic change
Go to the Options page for com_content and try all the show/hide options on that page to ensure they make sense.

If this is accepted we can look to do this for all config screens

avatar brianteeman brianteeman - open - 30 Apr 2016
avatar brianteeman brianteeman - change - 30 Apr 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Apr 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 30 Apr 2016
Category Components UI/UX
avatar brianteeman brianteeman - change - 30 Apr 2016
Easy No Yes
avatar andrepereiradasilva
andrepereiradasilva - comment - 30 Apr 2016

this is a cosmetic, but IMO also a great improvement for usability.

avatar andrepereiradasilva
andrepereiradasilva - comment - 30 Apr 2016

@brianteeman you only did it for the "Articles" tab right?

The other tabs should have showon to.

avatar brianteeman
brianteeman - comment - 30 Apr 2016

Yes I only did the Articles tab for now - if approved I will do the rest

avatar andrepereiradasilva
andrepereiradasilva - comment - 30 Apr 2016

ok then.

avatar brianteeman
brianteeman - comment - 30 Apr 2016

To be honest there arent as many opportunities to use showon with the other tabs ;)

avatar andrepereiradasilva andrepereiradasilva - test_item - 30 Apr 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 30 Apr 2016

I have tested this item :white_check_mark: successfully on 50c4bd7

Not that means much. But here goes my approval :smile:


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10149.

avatar andrepereiradasilva
andrepereiradasilva - comment - 30 Apr 2016

To be honest there arent as many opportunities to use showon with the other tabs ;)

there are some, at least:

  • versions in "Editing layout"
  • dates in "List layout"
  • pagination in "Shared"
avatar brianteeman
brianteeman - comment - 30 Apr 2016

yes and I will have to do the same showon stuff in the menu items

I would prefer to do it all in one PR so i just did this small one as a
proof of concept

On 30 April 2016 at 18:53, andrepereiradasilva notifications@github.com
wrote:

To be honest there arent as many opportunities to use showon with the
other tabs ;)

there are some, at least:

  • versions in "Editing layout"
  • dates in "List layout"
  • pagination in "Shared"


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#10149 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar andrepereiradasilva
andrepereiradasilva - comment - 30 Apr 2016

in reality, IMO, almost all xml should have the showon (components, modules, plugins, etc)

avatar brianteeman
brianteeman - comment - 30 Apr 2016

yes I agree - just want to get concensus and approval before doing this
change everywhere - its a big change

On 30 April 2016 at 19:10, andrepereiradasilva notifications@github.com
wrote:

in reality, IMO, almost all xml should have the showon (components,
modules, plugins, etc)


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#10149 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar andrepereiradasilva
andrepereiradasilva - comment - 30 Apr 2016

agree

avatar Twincarb Twincarb - test_item - 30 Apr 2016 - Tested successfully
avatar Twincarb
Twincarb - comment - 30 Apr 2016

I have tested this item :white_check_mark: successfully on 50c4bd7

This PR potentially will assist with new administrators where they can see options which are tied to a particular condition. But for everyone it gives a cleaner overview.

It's an idea that wouldn't be out of place if adopted by 3rd party extensions as well.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10149.

avatar wilsonge wilsonge - change - 30 Apr 2016
Milestone Added:
avatar wilsonge
wilsonge - comment - 30 Apr 2016

RTC

avatar wilsonge wilsonge - change - 30 Apr 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 30 Apr 2016
Labels Removed: ?
avatar brianteeman brianteeman - change - 1 May 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 1 May 2016

RTC again


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10149.

avatar joomla-cms-bot joomla-cms-bot - change - 1 May 2016
Milestone Removed:
avatar joomla-cms-bot joomla-cms-bot - change - 1 May 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 1 May 2016
Milestone Added:
avatar joomla-cms-bot
joomla-cms-bot - comment - 1 May 2016

This PR has received new commits.

CC: @andrepereiradasilva, @Twincarb


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10149.

avatar brianteeman brianteeman - change - 1 May 2016
Status Ready to Commit Pending
Labels
avatar brianteeman
brianteeman - comment - 1 May 2016

Removed RTC as new additions to complete this pr to update all tabs


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10149.

avatar joomla-cms-bot joomla-cms-bot - change - 1 May 2016
Labels Removed: ?
avatar Twincarb Twincarb - test_item - 1 May 2016 - Tested successfully
avatar Twincarb
Twincarb - comment - 1 May 2016

I have tested this item :white_check_mark: successfully on f5d55f4


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10149.

avatar joomla-cms-bot
joomla-cms-bot - comment - 1 May 2016

This PR has received new commits.

CC: @andrepereiradasilva, @Twincarb


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10149.

avatar andrepereiradasilva
andrepereiradasilva - comment - 1 May 2016

one last that can also have showon

image

The rest seems fine.

avatar joomla-cms-bot
joomla-cms-bot - comment - 1 May 2016

This PR has received new commits.

CC: @andrepereiradasilva, @Twincarb


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10149.

avatar andrepereiradasilva andrepereiradasilva - test_item - 1 May 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 1 May 2016

I have tested this item :white_check_mark: successfully on 5d95a97

Works fine. Thanks
Don't forget to add the "0" to the "List All categories" menu item type to when you do that one.
https://github.com/joomla/joomla-cms/pull/10149/files#diff-e1cfaa1f327e2fb6df5d2c06e0b8ea6aR594


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10149.

avatar brianteeman
brianteeman - comment - 1 May 2016

I will do that later but just so you know the way menu items has a show
global option pretty much prevents the use of showon in a menu option -
unless I missed something

On 1 May 2016 at 20:38, andrepereiradasilva notifications@github.com
wrote:

I have tested this item [image: :white_check_mark:] successfully on
5d95a97
5d95a97

Works fine. Thanks
Don't forget to add the "0" to the "List All categories" menu item type to
when you do that one.

https://github.com/joomla/joomla-cms/pull/10149/files#diff-e1cfaa1f327e2fb6df5d2c06e0b8ea6aR594

This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/10149
https://issues.joomla.org/tracker/joomla-cms/10149.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#10149 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar andrepereiradasilva
andrepereiradasilva - comment - 1 May 2016

just tested showon on a menu item type (alias) just as a PoC and worked fine.
https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_menus/models/forms/item_alias.xml

avatar brianteeman
brianteeman - comment - 1 May 2016

It works the problem is that because of showglobal you don't know if you
should be hiding something

avatar andrepereiradasilva
andrepereiradasilva - comment - 1 May 2016

i see, just hide if not show global?

avatar brianteeman
brianteeman - comment - 1 May 2016

I think its not worth it

On 1 May 2016 at 20:57, andrepereiradasilva notifications@github.com
wrote:

i see, just hide if not show global?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#10149 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar andrepereiradasilva
andrepereiradasilva - comment - 1 May 2016

ok

avatar BurtNL BurtNL - test_item - 2 May 2016 - Tested successfully
avatar BurtNL
BurtNL - comment - 2 May 2016

I have tested this item :white_check_mark: successfully on 5d95a97


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10149.

avatar brianteeman brianteeman - change - 2 May 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 2 May 2016

RTC thanks for testing


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10149.

avatar joomla-cms-bot joomla-cms-bot - change - 2 May 2016
Labels Added: ?
avatar rdeutz rdeutz - change - 3 May 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-05-03 07:14:02
Closed_By rdeutz
avatar rdeutz rdeutz - close - 3 May 2016
avatar rdeutz rdeutz - merge - 3 May 2016
avatar joomla-cms-bot joomla-cms-bot - close - 3 May 2016
avatar rdeutz rdeutz - reference | 8b842cd - 3 May 16
avatar rdeutz rdeutz - merge - 3 May 2016
avatar rdeutz rdeutz - close - 3 May 2016
avatar joomla-cms-bot joomla-cms-bot - change - 3 May 2016
Labels Removed: ?
avatar brianteeman brianteeman - head_ref_deleted - 3 May 2016
avatar JoomliC
JoomliC - comment - 14 May 2016

@brianteeman Thank you for all your job on showon!
Really a great improvement for UX ????

avatar Devportobello
Devportobello - comment - 18 Jul 2016

Test coverage not noticed the inconsistency of the show icons part
see : #11126

Add a Comment

Login with GitHub to post a comment