[#10148] - [com_templates] styles/templates views: Site/Admin and other changes
- Closed
- 2 May 2016
- Medium
- Build: staging
- # 10148
- Diff
- andrepereiradasilva:com_templates-site-admin
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 3 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
This PR makes some changes to com_templates list views (styles and templates):
For consistency, align com_templates list views with other views that have a location selector (modules, cache, installed languages) by adding the client selector (Site/Administrator) and removing the location (client) from ordering, columns and filters.
Adds a new filter
menuitem(Pages) in styles view to show the template styles assigned to a particular menu item.Improves the "Assigned" column (now "Pages") so it will give more information and be more aligned with modules list view.
Improves mobile view.
Other minor code style and code improvements.
Styles view
Before PR
After PR
Templates view
Before PR
After PR
Testing Instructions
- Apply patch
- Go to Extensions -> Templates -> Styles, and do a general test of all options and filters. Test also mobile views. Test the new
menuitem(Pages) filter - Go to Extensions -> Templates -> Templates, and do a general test of all options and filters. Test also mobile views.
- Test also if works properly with 3ยบ party templates.
- Test the two views in hathor to.
Observations
Code reviews, comments and/or suggestions are welcomed.
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
?
|
||
| Category | ⇒ | Components UI/UX |
| Labels | |||
| Labels | |||
| Category | Components UI/UX | ⇒ | Components Language & Strings UI/UX |
| Labels | |||
| Labels | |||
ok hathor working fine now.
Works great for Templates
Works great for Site Styles
But for Admin styles there are a few issues
1. there is still a filter for Select Page present which is not usable as it only shows site pages
2. you cant "assign" an admin template so the string should not be "not assigned"
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10148.
I have tested this item 
unsuccessfully on 9408960
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10148.
In fact the entire pages column is probably not useful in the admin styles view
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10148.
- there is still a filter for Select Page present which is not usable as it only shows site pages
That is the same problem that exists in #9987
that i know of, there is no way to "say" in the xml to not show that filter when admin client is selected.
I can have a look on how is it possible to do this.
2 . you cant "assign" an admin template so the string should not be "not assigned"
You're right. I will remove this column in admin.
This PR has received new commits.
CC: @brianteeman
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10148.
"2." solved
I can confirm point 2 is solved but with point 1 still there I would say we cant accept this PR yet
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10148.
in theory it should be showon="client_id:0" but doesn't work. it seams searchtools doesn't process showon.
This PR has received new commits.
CC: @brianteeman
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10148.
I have tested this item 
successfully on 9e9fcbd
GReat stuff
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10148.
With Default Test data installed, Beez3 is assigned to 2 pages.
Is it possible that when I select Beez3 in the search dropdown that when I select "Select Page" dropdown that the only items that show are the one's for the template selected?
Apart from that it works really well and simplifies it logically
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10148.
I have tested this item successfully on 9e9fcbd
@andrepereiradasilva
thanks for your hard work.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10148.
| Status | Pending | ⇒ | Ready to Commit |
| Labels | |||
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
I have tested this item successfully on 9e9fcbd
Great - thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10148.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-02 06:40:23 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
humm, need to change hathor override too.