? ? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
30 Apr 2016

Summary of Changes

Simple PR to improves the search tooltip and element label (accessibility) in com_content.
Also add the ability to search for author in featured view to have the same behaviour as the articles view.

Testing Instructions

Code review, or:
1. Apply patch
2. Go to Content -> Articles, check the tooltip in the search field.
3. Go to Content -> Featured, check the tooltip in the search field.
4. Go to frontend edit, click "+Article" in TinyMce and check the tooltip in the search field of the popup.

avatar andrepereiradasilva andrepereiradasilva - open - 30 Apr 2016
avatar andrepereiradasilva andrepereiradasilva - change - 30 Apr 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Apr 2016
Labels Added: ? ?
avatar joomla-cms-bot joomla-cms-bot - change - 30 Apr 2016
Labels Added: ? ?
avatar brianteeman brianteeman - change - 30 Apr 2016
Labels
avatar brianteeman brianteeman - change - 30 Apr 2016
Category Components UI/UX
avatar andrepereiradasilva andrepereiradasilva - change - 30 Apr 2016
Labels
avatar andrepereiradasilva andrepereiradasilva - change - 30 Apr 2016
The description was changed
avatar brianteeman brianteeman - test_item - 30 Apr 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 30 Apr 2016

I have tested this item :white_check_mark: successfully on de2f669


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10147.

avatar Twincarb Twincarb - test_item - 30 Apr 2016 - Tested unsuccessfully
avatar Twincarb
Twincarb - comment - 30 Apr 2016

I have tested this item :red_circle: unsuccessfully on de2f669

The functions work as expected, however on showing the tooltip in the front end the top of it is clipped as shown below.

desktop tooltip clipping

View on mobile

mobile tooltip clipping


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10147.

avatar brianteeman
brianteeman - comment - 30 Apr 2016

Good spot. I didnt check it properly but I see that too

On 30 April 2016 at 22:28, Twincarb notifications@github.com wrote:

I have tested this item [image: :red_circle:] unsuccessfully on de2f669
de2f669

The functions work as expected, however on showing the tooltip in the
front end the top of it is clipped as shown below.

[image: desktop tooltip clipping]
https://camo.githubusercontent.com/845f2bdad633f9581582521651c6e3d08b059f00/687474703a2f2f7333322e706f7374696d672e6f72672f63686c3633766664682f6a6f6f6d6c61312e6a7067

View on mobile

[image: mobile tooltip clipping]

https://camo.githubusercontent.com/b7814cf0890c940d62058fecd17cac7d1c2596aa/687474703a2f2f7333322e706f7374696d672e6f72672f6d36766f78793571742f6a6f6f6d6c61322e6a7067

This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/10147
https://issues.joomla.org/tracker/joomla-cms/10147.


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#10147 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar andrepereiradasilva
andrepereiradasilva - comment - 30 Apr 2016

reggarding the tooltips in modals with iframes, i think @JoomliC is working on PR to solve them.
So i ask you to please ignore that for now.

avatar andrepereiradasilva
andrepereiradasilva - comment - 30 Apr 2016

actually i think he solved it here #10076 (needs one more test)

avatar andrepereiradasilva
andrepereiradasilva - comment - 30 Apr 2016

i just tested this PR + @JoomliC modals PR (#10076) and all seems good.
In other words the tootlip problem is not related to this PR.

So @Twincarb please test again with the two patches applied.

avatar brianteeman
brianteeman - comment - 30 Apr 2016

I will retest in the morning

avatar Twincarb Twincarb - test_item - 30 Apr 2016 - Tested successfully
avatar Twincarb
Twincarb - comment - 30 Apr 2016

I have tested this item :white_check_mark: successfully on de2f669

Tested alongside PR(10076)
Which solves the desktop issue, there is still a tooltip issue on mobile devices, tested both with chrome and mobile. The mobile issue is unrelated to this PR I will add a comment to PR(10076)


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10147.

avatar JoomliC
JoomliC - comment - 1 May 2016

The mobile issue is unrelated to this PR

@Twincarb exactly about TinyMCE modals, not related to this PR (and i agree that TinyMCE modals on mobile are really bad and a shame to use as you have to touch tiny modal header and move to be able to navigate and view the close button...) ;-)
About tooltip, as placement is set to button, and the content of the modal articles and modules in TinyMCE is loaded inside an iframe (modal.php view) and i don't see how it's possible to have the tooltip issue there (but as TinyMCE is really bad on mobile... So waiting for your answer here: #10076 (comment) :+1: )

avatar JoomliC JoomliC - test_item - 1 May 2016 - Tested successfully
avatar JoomliC
JoomliC - comment - 1 May 2016

I have tested this item :white_check_mark: successfully on de2f669

I confirm a successfull test just done on my iOS mobile :+1:
And no change here concerning tooltip placement nor the none-responsiveness or TinyMCE modals ;-)

Good for RTC, and nice to be able to search by author!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10147.

avatar Twincarb
Twincarb - comment - 1 May 2016

@JoomliC Just found out I Can move a TinyMCE modal! Thank you for the heads up


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10147.

avatar brianteeman brianteeman - change - 1 May 2016
Status Pending Ready to Commit
Labels
avatar brianteeman
brianteeman - comment - 1 May 2016

Setting RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10147.

avatar joomla-cms-bot joomla-cms-bot - change - 1 May 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - reference | d840da1 - 1 May 16
avatar rdeutz rdeutz - merge - 1 May 2016
avatar rdeutz rdeutz - close - 1 May 2016
avatar rdeutz rdeutz - change - 1 May 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-05-01 10:27:38
Closed_By rdeutz
avatar andrepereiradasilva andrepereiradasilva - head_ref_deleted - 1 May 2016
avatar JoomliC
JoomliC - comment - 1 May 2016

@JoomliC Just found out I Can move a TinyMCE modal! Thank you for the heads up

You're welcome! ;-)
But really not an easy way to manage it this way on mobile...

avatar joomla-cms-bot joomla-cms-bot - change - 1 May 2016
Labels Removed: ?
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:

Add a Comment

Login with GitHub to post a comment