User tests: Successful: Unsuccessful:
New Pull Request for #7602 and Issue #7401 .
As requested by @wilsonge to contribute these changes back to the library (https://github.com/claviska/jquery-minicolors/), i did it . The updated library includes other fixes.
A special thanks to @claviska for his suggestions, help and the time he took in make it happen!
All documentation on this color picker library available here: http://labs.abeautifulsite.net/jquery-minicolors/
format
and keywords
hex
(current format), rgb
and rgba
transparent
, initial
, inherit
CSS-wide keywords can be assigned by setting the keywords
attribute to a comma-separated list of valid keywords: transparent
,inherit
,initial
XML: keywords="transparent,inherit,initial"
Usage: enter the keyword in the field input (script will allow only a keyword listed in the xml attribute)
See screen shot for testing.
For Joomla, i've integrate the rgb(a) format option as a one xml attribute. (no need to set a data-opacity attribute).
Format could be: hex
(default), rgb
or rgba
(with opacity slider)
XML: format="rgba"
Usage: Will return a validated color hex or rgb(a)
See screen shot for testing.
Add RTL support. If position is default, the picker will be on the left if RTL language (currently it's right on LTR).
The input value was converted to RTL before, but with issue in some cases. To prevent this, the input value will always be LTR as it is not to be translated or converted as a CSS code value.
NOTE: When this PR will be merged, i will update JDocs accordingly ;-)
Add these fields to the settings part of an xml file of one extension (eg. template Isis). Then go to that extension settings in the admin and test the different color fields.
<field name="color1" type="color" label="Color field default (HEX)" />
<field name="color2" type="color" label="HEX + keywords" keywords="transparent,initial,inherit" />
<field name="color3" type="color" label="RGB" format="rgb" />
<field name="color4" type="color" label="RGB + keywords" format="rgb" keywords="transparent,initial,inherit" />
<field name="color5" type="color" label="RGB(A)" format="rgba" />
<field name="color6" type="color" label="RGB(A) + keywords" format="rgba" keywords="transparent,initial,inherit" />
Status | New | ⇒ | Pending |
Labels |
Added:
?
|
Category | ⇒ | External Library JavaScript |
library jquery.minicolors.js latest version 2.2.4 released on 18 Mar. Can you clarify which one is in use here.
I have tested with no issues detected and functionality is as described
Will submit a success result once the version is identified.
library jquery.minicolors.js latest version 2.2.4 released on 18 Mar. Can you clarify which one is in use here.
@Twincarb Yes you're right, i've mentionned 2.2.3, but it's 2.2.4! (will update description)
I was mistaken by the package.json version which was not updated : https://github.com/claviska/jquery-minicolors/blob/master/package.json#L3 ;-)
So yes, no worry, it is the latest released version in this PR ! ;-)
I have tested this item successfully on 2211e19
Is it worth adding the version number to the .js file? I know the developer hasn't but I guess it's always worth asking him.
Then we have an easy way of comparing the version of the file.
@andrepereiradasilva, @Twincarb Thanks for testing!
Status | Pending | ⇒ | Ready to Commit |
Labels |
Added:
?
|
Milestone |
Added: |
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-02 06:38:42 |
Closed_By | ⇒ | rdeutz |
Labels |
Removed:
?
|
I have tested this item successfully on 2211e19
worked. had to clena browser cache after apply patch.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10129.