[#10130] - [com_users] all views: Add missing tooltips in search
- Fixed in Code Base
- 29 Apr 2016
- Medium
- Build: staging
- # 10130
- Diff
- andrepereiradasilva:patch-7
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Summary of Changes
Simple PR to add missing tootip to all views in the com_users search filters.
Testing Instructions
Code review.
or
- Apply patch
- Go to Users -> User Groups, check the tootip in the search field.
- Go to Users -> Viewing Access Levels, check the tootip in the search field.
- Go to Users -> User Notes, check the tootip in the search field.
- Activate debug in global config
- Go to Users -> Manage, click "Debug Permissions Report" and check the tootip in the search field.
- Go to Users -> User Groups, click "Debug Permissions Report" and check the tootip in the search field.
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
?
|
||
That doesnt seem correct - I will need to check it in context later - i am
on my phone
On 29 April 2016 at 13:07, Marc-Antoine Thevenet notifications@github.com
wrote:
I have tested this item [image:
] successfully on
c3e7536
c3e7536@brianteeman https://github.com/brianteeman
Is it ok for having in COM_USERS_SEARCH_IN_NAME="Search in user name,
username or email. Prefix with ID: to search for a user ID."user name and username ?
This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/10130
https://issues.joomla.org/tracker/joomla-cms/10130.—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#10130 (comment)
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
for the record, i don't like it either, if you can suggest a better text it will be welcomed.
i will do that in a separate PR
On 29 April 2016 at 13:49, andrepereiradasilva notifications@github.com
wrote:
for the record, i don't like it either, if you can suggest a better text
it will be welcomed.—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#10130 (comment)
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
rdeutz
- | Milestone |
Added: |
||
ok, please test this one.
This PR has received new commits.
CC: @MATsxm
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10130.
done, and for "COM_USERS_SEARCH_IN_NOTE_TITLE" ?
This PR has received new commits.
CC: @MATsxm
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10130.
done, and done
This PR has received new commits.
CC: @MATsxm
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10130.
... and done.
I have tested this item successfully on c3e7536
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10130.
At some point we will have to review the text on all these search strings - i will add it to the en-gb tasklist
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10130.
| Status | Pending | ⇒ | Ready to Commit |
| Labels | |||
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-04-29 15:46:54 |
| Closed_By | ⇒ | rdeutz |
| Milestone |
Removed: |
||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
| Labels |
Removed:
?
|
||
I have tested this item
successfully on c3e7536
@brianteeman
Is it ok for having in
COM_USERS_SEARCH_IN_NAME="Search in user name, username or email. Prefix with ID: to search for a user ID."user nameandusername?This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10130.