Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#10074] - Update Module Select title

? Success

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
24 Apr 2016

Summary of Changes

A recent PR changed the title for the Modules page to display if it was Site or Administrator modules
This PR adds the same functionality to the New Modules Select

avatar brianteeman brianteeman - open - 24 Apr 2016
avatar brianteeman brianteeman - change - 24 Apr 2016
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Apr 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 24 Apr 2016
Category ⇒ Components UI/UX
avatar brianteeman brianteeman - change - 24 Apr 2016
Easy No ⇒ Yes
avatar andrepereiradasilva
andrepereiradasilva - comment - 24 Apr 2016

While you are at it. in the create/edit module view, IMO it should have those title changes too.

Currently is like this
image

avatar andrepereiradasilva
andrepereiradasilva - comment - 24 Apr 2016

i tested with success i mark it when you solve the travis stuff

avatar brianteeman
brianteeman - comment - 24 Apr 2016

travis is happy

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10074.

avatar andrepereiradasilva andrepereiradasilva - test_item - 24 Apr 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 24 Apr 2016

I have tested this item :white_check_mark: successfully on bdbb600

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10074.

avatar JoomliC
JoomliC - comment - 24 Apr 2016

Hummm... don't know why, but the patch is applied (i have checked the code), on localhost, but when select "admin" modules, and then click on "New" button, i still have "site" in header:
capture d ecran 2016-04-24 a 18 00 32

I don't know why... not related to cache...
The code seems good... Any idea ?

avatar brianteeman
brianteeman - comment - 24 Apr 2016

No idea. Couldn't replicate it

avatar JoomliC
JoomliC - comment - 24 Apr 2016

Sorry, i didn't have updated sraging there, and a change in model select with filter.client_id state changed to client_id : 99866ab

So, it ok after test on latest staging! :+1:

avatar JoomliC JoomliC - test_item - 24 Apr 2016 - Tested successfully
avatar JoomliC
JoomliC - comment - 24 Apr 2016

I have tested this item :white_check_mark: successfully on bdbb600

Test success on latest staging.
Work as described, and fix the issue in select new module page header

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10074.

avatar brianteeman brianteeman - change - 24 Apr 2016
Status Pending ⇒ Ready to Commit
avatar brianteeman
brianteeman - comment - 24 Apr 2016

Rtc

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10074.

avatar joomla-cms-bot joomla-cms-bot - change - 24 Apr 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 24 Apr 2016
Milestone Added:
avatar rdeutz rdeutz - reference | f4dac47 - 25 Apr 16
avatar rdeutz rdeutz - merge - 25 Apr 2016
avatar rdeutz rdeutz - close - 25 Apr 2016
avatar rdeutz rdeutz - change - 25 Apr 2016
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-04-25 08:23:45
Closed_By ⇒ rdeutz
avatar rdeutz rdeutz - close - 25 Apr 2016
avatar rdeutz rdeutz - merge - 25 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - close - 25 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - change - 25 Apr 2016
Labels Removed: ?
avatar brianteeman brianteeman - head_ref_deleted - 25 Apr 2016
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:

Add a Comment

Login with GitHub to post a comment