[#10075] - [modal] Improve iframe modals: categories, contacts, newsfeeds
- Closed
- 11 May 2016
- Medium
- Build: staging
- # 10075
- Diff
- JoomliC:improve-iframe-modals
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Part 2 of iframe inside modals. (see for versions here: #9995
Note: A one-PR will be done for Hathor overrides (as done in PR for versions #9995)
Summary of Changes
- When Bootstrap modal loads an iframe, BS tooltips with placement top are truncated at the top border of the iframe. (no auto placement in BS2). This PR sets the tooltip placement to bottom to fix this issue.
- Remove inline CSS
- Content is embedded in a container div (using already existing container-popup class for modal.php)
- Add empty lines to improve the readability
-
newsfeedsadd search input description for tooltip (form xml)
Testing Instructions (Multilanguages enabled!)
-
categoriesGo to Contents > Categories > open a categorie, and go to Association to select associated category. On click, open the modal changed for categories. -
contactsGo to Components > Contacts > open a contact, and go to Association to select associated contact. On click, open the modal changed for contacts. -
newsfeedsGo to Menus Manager > Add New Menu Item > Type "single newsfeed". Click on select the feed to open the modal changed for newsfeeds. - For Newsfeeds component, check if in modal (see above) and the list of feeds, the added tooltip description for the search input.
To be testing on latest staging.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Title |
|
||||||
| Title |
|
||||||
| Category | ⇒ | Components UI/UX |
@joomlic i am a bit confused. is this pr still for testing or have your newer ones replaced it
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10075.
It was still for testing, but i will redo it with viewport addition ;-)
@andrepereiradasilva the conflict seems with this one #10178 (open after, but already merged ;-) )
So i close this one, and will redo it on staging (maybe in a few hours ;-) )
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-11 15:48:04 |
| Closed_By | ⇒ | JoomliC |
@brianteeman in the same time, i make a list of other modal to be updated, so will see to do each one by one, to help faster testing ;-)
Thanks
On 11 May 2016 at 16:48, Cyril Rezé notifications@github.com wrote:
It was still for testing, but i will redo it with viewport addition ;-)
@andrepereiradasilva https://github.com/andrepereiradasilva the
conflict seems with this one #10178
#10178 (open after, but
already merged ;-) )So i close this one, and will redo it on staging (maybe in a few hours ;-)
)—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#10075 (comment)
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
I have tested this item
successfully on 622f1dd
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10075.