User tests: Successful: Unsuccessful:
This PR adds searchtools to com_users modal layout users view and does some minor visual improvements.
Note: You can test other "Select User" modals (ex: in a contact, user notes, messaging, or others)
Status | New | ⇒ | Pending |
Labels |
Added:
?
|
Title |
|
Title |
|
Category | ⇒ | Components UI/UX |
Yes they are, but @JoomliC will make a PR to solves in all iframe modals.
And now this one.
See #10013 (comment)
I have tested this item successfully on fd3de89
Yes they are, but @JoomliC will make a PR to solves in all iframe modals.
Yes, but as the PR i'm working on (maybe ready for today, as core done, and just the Hathor overrides to update or create (as missing for some)) is included users modal...
So it will conflict with my PR (including categories
, contacts
and newsfeeds
)... and missing in your PR the Hathor override too to be updated for users...
For this reason, and to make it easier, i will remove users from my PR, and so you can add the tooltip placement directly in your PR, but will you add too the Hathor changes ? (based on Versions HTML structure here: https://github.com/JoomliC/joomla-cms/blob/c9b9f1a484a3a649b29dbe4e8f8d36db24f80ceb/administrator/templates/hathor/html/com_contenthistory/history/modal.php )
For tooltip in Users Modal, you can add this:
JHtml::_('bootstrap.tooltip', '#filter_search', array('title' => JText::_('COM_USERS_SEARCH_IN_NAME'), 'placement' => 'bottom'));
JHtml::_('bootstrap.tooltip', '.hasTooltip', array('placement' => 'bottom'));
But, I wonder if we should create a new string for the search input tooltip, as the string name is constructed as all other search input description are: COM_COMPONENT_FILTER_SEARCH_DESC
Or is it ok to still use the existing string COM_USERS_SEARCH_IN_NAME ?
For this reason, and to make it easier, i will remove users from my PR, and so you can add the tooltip placement directly in your PR, but will you add too the Hathor changes ? (based on Versions HTML structure here: https://github.com/JoomliC/joomla-cms/blob/c9b9f1a484a3a649b29dbe4e8f8d36db24f80ceb/administrator/templates/hathor/html/com_contenthistory/history/modal.php )
ok, i will do it in this PR, but i will not change hathor.
For tooltip in Users Modal, you can add this:
JHtml::_('bootstrap.tooltip', '#filter_search', array('title' => JText::_('COM_USERS_SEARCH_IN_NAME'), 'placement' => 'bottom'));
JHtml::_('bootstrap.tooltip', '.hasTooltip', array('placement' => 'bottom'));
But, I wonder if we should create a new string for the search input tooltip, as the string name is constructed as all other search input description are: COM_COMPONENT_FILTER_SEARCH_DESC
Or is it ok to still use the existing string COM_USERS_SEARCH_IN_NAME ?
The tooltip text comes from the fields xml, don't change that. See https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_users/models/forms/filter_users.xml#L8
This PR has received new commits.
CC: @brianteeman
ok tooltips now placed on the button.
@JoomliC i changed a little your method to read the search field tooltip from the fields xml.
See b305d12
@brianteeman just the tooltips placement changed.
ok, i will do it in this PR, but i will not change hathor.
We asked me so, when i did versions
modal redo and fixes, but, so let's say to the PLT that i will do the Hathor override update myself to prevent this one to no be RTC ;-)
And in fact, will do only a separated PR for Hathor modals, after the PR i will add in a few minutes ;-)
@JoomliC i changed a little your method to read the search field tooltip from the fields xml.
Yes!
Really better, and will do the same for PR to come today about categories
, newsfeeds
and contacts
;-)
I have tested this item successfully on b305d12
We asked me so, when i did versions modal redo and fixes, but, so let's say to the PLT that i will do the Hathor override update myself to prevent this one to no be RTC ;-)
yes i know. but the propose of this PR is just implement searchtools in this modal view in isis. the tooltip placement is a bonus
and thanks for testing!
@andrepereiradasilva yes but you did too the change for container ;-)
But i've decided to do only one PR only for Hathor, and i'm currently adding the PR for part 2 of improve ifram modals ;-)
I have tested this item successfully on b305d12
Status | Pending | ⇒ | Ready to Commit |
Labels |
Added:
?
|
Milestone |
Added: |
thanks for testing @brianteeman
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-04-25 08:22:41 |
Closed_By | ⇒ | rdeutz |
Labels |
Removed:
?
|
Milestone |
Removed: |
Milestone |
Added: |
Milestone |
Added: |
Milestone |
Removed: |
@123monsite-regis Please open new issue or Pull Request (PR).
All the tooltips are obscured?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10073.