? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
24 Apr 2016

Description

This PR adds searchtools to com_users modal layout users view and does some minor visual improvements.

Before PR

image

After PR

image

How to test

  1. Use latest staging and apply patch
  2. Edit some article and go to "Publishing" tab
  3. In the "Created by" press the user icon the modal will appear
  4. Check if search, filters, ordering and pagination are working properly in modal.
  5. Test selecting a user or "-No User -"

Note: You can test other "Select User" modals (ex: in a contact, user notes, messaging, or others)

avatar andrepereiradasilva andrepereiradasilva - open - 24 Apr 2016
avatar andrepereiradasilva andrepereiradasilva - change - 24 Apr 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Apr 2016
Labels Added: ?
avatar andrepereiradasilva andrepereiradasilva - change - 24 Apr 2016
Title
[com_users] add searchtools to modal layout and solves bugs
[com_users] add searchtools to modal layout
avatar andrepereiradasilva andrepereiradasilva - change - 24 Apr 2016
Title
[com_users] add searchtools to modal layout and solves bugs
[com_users] add searchtools to modal layout
avatar brianteeman brianteeman - change - 24 Apr 2016
Category Components UI/UX
avatar andrepereiradasilva andrepereiradasilva - change - 24 Apr 2016
The description was changed
avatar brianteeman
brianteeman - comment - 24 Apr 2016

All the tooltips are obscured?

screen shot 2016-04-24 at 05 48 59


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10073.

avatar andrepereiradasilva
andrepereiradasilva - comment - 24 Apr 2016

Yes they are, but @JoomliC will make a PR to solves in all iframe modals.

  • Menu item: Single Article or Article through language association
  • Menu item: Single Contact or Contact through language association
  • Menu item: Single News feed or News feed through language association
  • Category through language association

And now this one.

See #10013 (comment)

avatar andrepereiradasilva
andrepereiradasilva - comment - 24 Apr 2016

And before you ask :smile:, the activated filter ("Unactivated" value) does not work.

But that is already solved in #10042 which needs one more test.

avatar brianteeman brianteeman - test_item - 24 Apr 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 24 Apr 2016

I have tested this item :white_check_mark: successfully on fd3de89


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10073.

avatar JoomliC
JoomliC - comment - 24 Apr 2016

Yes they are, but @JoomliC will make a PR to solves in all iframe modals.

Yes, but as the PR i'm working on (maybe ready for today, as core done, and just the Hathor overrides to update or create (as missing for some)) is included users modal...
So it will conflict with my PR (including categories, contacts and newsfeeds)... and missing in your PR the Hathor override too to be updated for users...
For this reason, and to make it easier, i will remove users from my PR, and so you can add the tooltip placement directly in your PR, but will you add too the Hathor changes ? (based on Versions HTML structure here: https://github.com/JoomliC/joomla-cms/blob/c9b9f1a484a3a649b29dbe4e8f8d36db24f80ceb/administrator/templates/hathor/html/com_contenthistory/history/modal.php )

For tooltip in Users Modal, you can add this:

JHtml::_('bootstrap.tooltip', '#filter_search', array('title' => JText::_('COM_USERS_SEARCH_IN_NAME'), 'placement' => 'bottom'));
JHtml::_('bootstrap.tooltip', '.hasTooltip', array('placement' => 'bottom'));

But, I wonder if we should create a new string for the search input tooltip, as the string name is constructed as all other search input description are: COM_COMPONENT_FILTER_SEARCH_DESC
Or is it ok to still use the existing string COM_USERS_SEARCH_IN_NAME ?

avatar andrepereiradasilva
andrepereiradasilva - comment - 24 Apr 2016

For this reason, and to make it easier, i will remove users from my PR, and so you can add the tooltip placement directly in your PR, but will you add too the Hathor changes ? (based on Versions HTML structure here: https://github.com/JoomliC/joomla-cms/blob/c9b9f1a484a3a649b29dbe4e8f8d36db24f80ceb/administrator/templates/hathor/html/com_contenthistory/history/modal.php )

ok, i will do it in this PR, but i will not change hathor.

For tooltip in Users Modal, you can add this:

JHtml::_('bootstrap.tooltip', '#filter_search', array('title' => JText::_('COM_USERS_SEARCH_IN_NAME'), 'placement' => 'bottom'));
JHtml::_('bootstrap.tooltip', '.hasTooltip', array('placement' => 'bottom'));

But, I wonder if we should create a new string for the search input tooltip, as the string name is constructed as all other search input description are: COM_COMPONENT_FILTER_SEARCH_DESC
Or is it ok to still use the existing string COM_USERS_SEARCH_IN_NAME ?

The tooltip text comes from the fields xml, don't change that. See https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_users/models/forms/filter_users.xml#L8

avatar joomla-cms-bot
joomla-cms-bot - comment - 24 Apr 2016

This PR has received new commits.

CC: @brianteeman


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10073.

avatar andrepereiradasilva
andrepereiradasilva - comment - 24 Apr 2016

ok tooltips now placed on the button.

@JoomliC i changed a little your method to read the search field tooltip from the fields xml.
See b305d12

@brianteeman just the tooltips placement changed.

image

avatar JoomliC
JoomliC - comment - 24 Apr 2016

ok, i will do it in this PR, but i will not change hathor.

We asked me so, when i did versions modal redo and fixes, but, so let's say to the PLT that i will do the Hathor override update myself to prevent this one to no be RTC ;-)

And in fact, will do only a separated PR for Hathor modals, after the PR i will add in a few minutes ;-)

@JoomliC i changed a little your method to read the search field tooltip from the fields xml.

Yes! :+1:
Really better, and will do the same for PR to come today about categories, newsfeeds and contacts ;-)

avatar JoomliC JoomliC - test_item - 24 Apr 2016 - Tested successfully
avatar JoomliC
JoomliC - comment - 24 Apr 2016

I have tested this item :white_check_mark: successfully on b305d12


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10073.

avatar andrepereiradasilva
andrepereiradasilva - comment - 24 Apr 2016

We asked me so, when i did versions modal redo and fixes, but, so let's say to the PLT that i will do the Hathor override update myself to prevent this one to no be RTC ;-)

yes i know. but the propose of this PR is just implement searchtools in this modal view in isis. the tooltip placement is a bonus :smile:

avatar andrepereiradasilva
andrepereiradasilva - comment - 24 Apr 2016

and thanks for testing!

avatar JoomliC
JoomliC - comment - 24 Apr 2016

@andrepereiradasilva yes but you did too the change for container ;-)
But i've decided to do only one PR only for Hathor, and i'm currently adding the PR for part 2 of improve ifram modals ;-)

avatar brianteeman brianteeman - test_item - 24 Apr 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 24 Apr 2016

I have tested this item :white_check_mark: successfully on b305d12


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10073.

avatar brianteeman brianteeman - change - 24 Apr 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 24 Apr 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10073.

avatar joomla-cms-bot joomla-cms-bot - change - 24 Apr 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 24 Apr 2016
Milestone Added:
avatar andrepereiradasilva
andrepereiradasilva - comment - 24 Apr 2016

thanks for testing @brianteeman

avatar rdeutz rdeutz - reference | fd4fe92 - 25 Apr 16
avatar rdeutz rdeutz - merge - 25 Apr 2016
avatar rdeutz rdeutz - close - 25 Apr 2016
avatar rdeutz rdeutz - close - 25 Apr 2016
avatar rdeutz rdeutz - merge - 25 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - close - 25 Apr 2016
avatar rdeutz rdeutz - change - 25 Apr 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-04-25 08:22:41
Closed_By rdeutz
avatar joomla-cms-bot joomla-cms-bot - change - 25 Apr 2016
Labels Removed: ?
avatar andrepereiradasilva andrepereiradasilva - head_ref_deleted - 25 Apr 2016
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar wojsmol
wojsmol - comment - 9 Aug 2017

@123monsite-regis Please open new issue or Pull Request (PR).

avatar alikon
alikon - comment - 9 Aug 2017

not sure if related but i've opened this new one #17460

avatar 123monsite-regis
123monsite-regis - comment - 10 Aug 2017

ok, i done a PR : #17463
@alikon , sorry, your issue is not related to my patch whereas it's on the same view i think.

Add a Comment

Login with GitHub to post a comment