[#10072] - Create a valid HTML id value for lists
- Fixed in Code Base
- 25 Apr 2016
- Medium
- Build: staging
- # 10072
- Diff
- roland-d:create-valid-id-value
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
When we do not provide an ID for a select or grouped select list Joomla will create the ID based on the name of the field. The name is more permissive than an ID. We already remove brackets from the name but spaces are also not allowed in IDs. This pull request removes the spaces from the generated ID value.
Testing Instructions
- Add the following code to the file administrator/components/com_banners/views/banner/tmpl/edit.php after line 49
<?php echo JHtml::_(
'select.genericlist',
array(1,2),
'Desc. field',
);
?>- Go to Components -> Banners
- Click on New
- Open the browser console by pressing F12 or right click and select Inspect
- Click on the Console tab in the Inspector
- Click on Save
- It is expected you get an error that the Name field is required but nothing happens.
- Look at the Console tab in Inspector and you will see the following error:
Uncaught Error: Syntax error, unrecognized expression: #Desc. field-lbl - Apply the patch
- Reload the page
- Click on Save
- You will now get the error that the Name field is required.
- Change is successful
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Milestone |
Added: |
||
| Category | ⇒ | Fields Libraries |
| Milestone |
Removed: |
||
@yvesh Ideally we filter everything to make it adhere to the standard, not sure what the impact will be and where it may be a B/C issue. The brackets are OK for names as it constitutes an array. As for the space in and ID, you simply can't target the element, so it will never work. At least for jQuery, a space in the name doesn't seem to be a problem.
I have tested this item 
successfully on 607a42e
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10072.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-04-25 12:55:57 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
| Milestone |
Removed: |
||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
I have tested this item
successfully on 607a42e
Tested, works as expected.
@roland-d What about the name attribute though? It still contains a space.. I know this is not important for the javascript validation, but when we do it for the id we should probably do it for the name also.
And what about filtering other special characters? In HTML 5 everything is allowed except the space, but in XHTML / HTML 4..
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10072.