? Success
Pull Request for # 9822

User tests: Successful: Unsuccessful:

avatar JoomliC
JoomliC
20 Apr 2016

Pull Request for Issue #9822 .

Summary of Changes

  • content is embedded in a container div (using already existing container-popup class for modal.php)
  • add a few empty lines to improve the readability
  • adjust .container-popup padding

Testing Instructions

  • Test with TinyMCE editor
  • Go to: Content > article, and edit an article
  • clic on editor toolbar buttons: module, article, image and pagebreak
  • control if padding is ok, as well as tooltip visible
  • verify if issue #9822 for Page break is fixed

Example with Modules modal:
Before Patch
capture d ecran 2016-04-20 a 17 30 22

After Patch
capture d ecran 2016-04-21 a 00 56 58

Page Break issue #9822 solved:
Before Patch
capture d ecran 2016-04-20 a 19 58 22

After Patch
capture d ecran 2016-04-20 a 19 59 59

avatar JoomliC JoomliC - open - 20 Apr 2016
avatar JoomliC JoomliC - change - 20 Apr 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Apr 2016
Labels Added: ?
avatar JoomliC JoomliC - change - 20 Apr 2016
The description was changed
avatar brianteeman brianteeman - change - 20 Apr 2016
Category Components Layout UI/UX
avatar brianteeman brianteeman - change - 20 Apr 2016
Rel_Number 0 9822
Relation Type Pull Request for
avatar brianteeman brianteeman - test_item - 20 Apr 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 20 Apr 2016

I have tested this item :white_check_mark: successfully on 577576c

Thanks - great stuff


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10013.

avatar andrepereiradasilva
andrepereiradasilva - comment - 20 Apr 2016

pleazse don't add the hr between the searchtools and the results. The other views don't have that (consistency).

Also is it possible to make the TinyMCE modals (articles/modules) with flexible width like the other modals?
For instance, if the width is larger, the ordering and limit select boxes will appear.

And i think you need to check frontend edit modals in tinymce too.

And, of course, great job on modals!

avatar JoomliC
JoomliC - comment - 20 Apr 2016

pleazse don't add the hr between the searchtools and the results. The other views don't have that (sonsistency).

I added it as it was already in some modal reviewed for styling issue: 12ed157#diff-8dbab11ae07a5edb26df7ac1ef5cdf74R52
But i agree the hr there is when buttons.
So, to be removed if search tools ? or to be added too in main list ? (as better spacing... or a minor change later to add extra margin bottom search tools ?
What's your advice on this point @brianteeman ?

Also is it possible to make the TinyMCE modals with flexible width like the other modals?

This is TinyMCE modals, not Joomla core ones. ;-)
This PR is only for contents loaded inside an iframe, in a modal.
I would say working on responsive TinyMCE modals is maybe another PR for... TinyMCE library ?

avatar andrepereiradasilva
andrepereiradasilva - comment - 20 Apr 2016

So, to be removed if search tools ? or to be added too in main list ? (as better spacing... or a minor change later to add extra margin bottom search tools ?

to be removed if searchtools IMO

This is TinyMCE modals, not Joomla core ones ;-)
This PR is only for contents loaded inside an iframe, in a modal.

I know, i mean in another PR
For instance, if the width is larger, the ordering and limit select boxes of searchtools will appear.

Also, i think you need to check frontend edit modals in tinymce too.

avatar joomla-cms-bot
joomla-cms-bot - comment - 20 Apr 2016

This PR has received new commits.

CC: @brianteeman


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10013.

avatar joomla-cms-bot
joomla-cms-bot - comment - 20 Apr 2016

This PR has received new commits.

CC: @brianteeman


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10013.

avatar joomla-cms-bot
joomla-cms-bot - comment - 20 Apr 2016

This PR has received new commits.

CC: @brianteeman


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10013.

avatar joomla-cms-bot
joomla-cms-bot - comment - 20 Apr 2016

This PR has received new commits.

CC: @brianteeman


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10013.

avatar joomla-cms-bot
joomla-cms-bot - comment - 20 Apr 2016

This PR has received new commits.

CC: @brianteeman


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10013.

avatar JoomliC
JoomliC - comment - 20 Apr 2016

to be removed if searchtools IMO

@andrepereiradasilva Done!
Removed < hr /> after Search Tools

For instance, if the width is larger, the ordering and limit select boxes of searchtools will appear.

Responsive design... in media queries (hidden-phone) in think... But, as you added Seach tools in some modals, you may know this already ;-)
Not in context of this PR, but after reading some comment on the name "Search Tools" (#9127), i'm wondering if search field and ordering should be integrated all together with all search filters, which then make sense to name this button "Search Tools"...

Also, i think you need to check frontend edit modals in tinymce too.

Oh yes! Forgot Beez3 and Protostar, where, indead the class container-popup was missing...

I think it's ok now ?!

@brianteeman Sorry, need re-testing as missing css change for frontend (Protostar and Beez3), and removal of the < hr /> between search tools and list of items, as suggested by @andrepereiradasilva .
Thanks!

avatar andrepereiradasilva
andrepereiradasilva - comment - 20 Apr 2016

@JoomliC check the searchtools tooltips in the backend tinymce article modal.

The rest seems fine.

There are also other modals :):

  • Menu item: Single Article or Article through language association
  • Menu item: Single Contact or Contact through language association
  • Menu item: Single News feed or News feed through language association
  • Category through language association

But i guess those can go in another PR

avatar JoomliC
JoomliC - comment - 20 Apr 2016

@JoomliC check the searchtools tooltips in the backend tinymce article modal.

Do you mean tooltip truncated for you on windows ? (i don't have issue with top, before and after patch, but added 3 px more than the previously inline style, to padding top for the content).
And so thought setting tooltip placement to bottom not needed.
Could you attach a screenshot ?

Menu item: Single Article or Article through language association
Menu item: Single Contact or Contact through language association
Menu item: Single News feed or News feed through language association
Category through language association

Not only, as there are too almost all the modal.php loaded inside iframe (but waiting first to complete the PR for Versions, as even if core fixed, i was asked at final to fix Hathor, which is already not good since a long time... :-( )

avatar andrepereiradasilva andrepereiradasilva - test_item - 20 Apr 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 20 Apr 2016

I have tested this item :white_check_mark: successfully on cbb6565

sorry! it was browser cache...

great job!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10013.

avatar JoomliC
JoomliC - comment - 20 Apr 2016

Oh yes, the template.css change ;-) (need always a cache refresh when css changes)
Thanks for testing! :+1:

avatar brianteeman brianteeman - test_item - 22 Apr 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 22 Apr 2016

I have tested this item :white_check_mark: successfully on cbb6565


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10013.

avatar brianteeman brianteeman - change - 22 Apr 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 22 Apr 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10013.

avatar joomla-cms-bot joomla-cms-bot - change - 22 Apr 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 22 Apr 2016
Milestone Added:
avatar rdeutz rdeutz - reference | 3de7618 - 22 Apr 16
avatar rdeutz rdeutz - merge - 22 Apr 2016
avatar rdeutz rdeutz - close - 22 Apr 2016
avatar rdeutz rdeutz - close - 22 Apr 2016
avatar rdeutz rdeutz - merge - 22 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - close - 22 Apr 2016
avatar rdeutz rdeutz - change - 22 Apr 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-04-22 19:17:04
Closed_By rdeutz
avatar joomla-cms-bot joomla-cms-bot - change - 22 Apr 2016
Labels Removed: ?
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:

Add a Comment

Login with GitHub to post a comment