User tests: Successful: Unsuccessful:
Pull Request for Issue #9822 .
.container-popup
paddingExample with Modules modal:
Before Patch
Page Break issue #9822 solved:
Before Patch
Status | New | ⇒ | Pending |
Labels |
Added:
?
|
Category | ⇒ | Components Layout UI/UX |
Rel_Number | 0 | ⇒ | 9822 |
Relation Type | ⇒ | Pull Request for |
pleazse don't add the hr
between the searchtools and the results. The other views don't have that (consistency).
Also is it possible to make the TinyMCE modals (articles/modules) with flexible width like the other modals?
For instance, if the width is larger, the ordering and limit select boxes will appear.
And i think you need to check frontend edit modals in tinymce too.
And, of course, great job on modals!
pleazse don't add the hr between the searchtools and the results. The other views don't have that (sonsistency).
I added it as it was already in some modal reviewed for styling issue: 12ed157#diff-8dbab11ae07a5edb26df7ac1ef5cdf74R52
But i agree the hr there is when buttons.
So, to be removed if search tools ? or to be added too in main list ? (as better spacing... or a minor change later to add extra margin bottom search tools ?
What's your advice on this point @brianteeman ?
Also is it possible to make the TinyMCE modals with flexible width like the other modals?
This is TinyMCE modals, not Joomla core ones. ;-)
This PR is only for contents loaded inside an iframe, in a modal.
I would say working on responsive TinyMCE modals is maybe another PR for... TinyMCE library ?
So, to be removed if search tools ? or to be added too in main list ? (as better spacing... or a minor change later to add extra margin bottom search tools ?
to be removed if searchtools IMO
This is TinyMCE modals, not Joomla core ones ;-)
This PR is only for contents loaded inside an iframe, in a modal.
I know, i mean in another PR
For instance, if the width is larger, the ordering and limit select boxes of searchtools will appear.
Also, i think you need to check frontend edit modals in tinymce too.
This PR has received new commits.
CC: @brianteeman
This PR has received new commits.
CC: @brianteeman
This PR has received new commits.
CC: @brianteeman
This PR has received new commits.
CC: @brianteeman
This PR has received new commits.
CC: @brianteeman
to be removed if searchtools IMO
@andrepereiradasilva Done!
Removed < hr />
after Search Tools
For instance, if the width is larger, the ordering and limit select boxes of searchtools will appear.
Responsive design... in media queries (hidden-phone) in think... But, as you added Seach tools in some modals, you may know this already ;-)
Not in context of this PR, but after reading some comment on the name "Search Tools" (#9127), i'm wondering if search field and ordering should be integrated all together with all search filters, which then make sense to name this button "Search Tools"...
Also, i think you need to check frontend edit modals in tinymce too.
Oh yes! Forgot Beez3 and Protostar, where, indead the class container-popup was missing...
I think it's ok now ?!
@brianteeman Sorry, need re-testing as missing css change for frontend (Protostar and Beez3), and removal of the < hr />
between search tools and list of items, as suggested by @andrepereiradasilva .
Thanks!
@JoomliC check the searchtools tooltips in the backend tinymce article modal.
The rest seems fine.
There are also other modals :):
But i guess those can go in another PR
@JoomliC check the searchtools tooltips in the backend tinymce article modal.
Do you mean tooltip truncated for you on windows ? (i don't have issue with top, before and after patch, but added 3 px more than the previously inline style, to padding top for the content).
And so thought setting tooltip placement to bottom not needed.
Could you attach a screenshot ?
Menu item: Single Article or Article through language association
Menu item: Single Contact or Contact through language association
Menu item: Single News feed or News feed through language association
Category through language association
Not only, as there are too almost all the modal.php loaded inside iframe (but waiting first to complete the PR for Versions, as even if core fixed, i was asked at final to fix Hathor, which is already not good since a long time... :-( )
I have tested this item successfully on cbb6565
sorry! it was browser cache...
great job!
Oh yes, the template.css change ;-) (need always a cache refresh when css changes)
Thanks for testing!
I have tested this item successfully on cbb6565
Status | Pending | ⇒ | Ready to Commit |
Labels |
Added:
?
|
Milestone |
Added: |
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-04-22 19:17:04 |
Closed_By | ⇒ | rdeutz |
Labels |
Removed:
?
|
Milestone |
Removed: |
Milestone |
Added: |
Milestone |
Added: |
Milestone |
Removed: |
I have tested this item successfully on 577576c
Thanks - great stuff
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10013.