User tests: Successful: Unsuccessful:
Pull Request for Issue # .
added the class art-featured to featured articles in category blog view
Create a featured leading article & intro article, then create non-featured articles for leading / intro. See if the class art-featured appears on the featured articles only.
Status | New | ⇒ | Pending |
Labels |
Added:
?
|
You are entirely right. Is there a way for me to make this change now?
Do it as I described. Your original Pull Request will show the nam of the branch on your own repo that you need to edit.
Closing this here
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-04-20 18:18:43 |
Closed_By | ⇒ | brianteeman |
Does that mean I need to go to the other branch and amend the files there?
yes that is what I wrote
On 20 April 2016 at 19:19, uglyeoin notifications@github.com wrote:
Does that mean I need to go to the other branch and amend the files there?
—
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub
#10014 (comment)
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
@brianteeman it only works for me when I haven't push something to a remote repo, anyway, can be me
I am still unsure as to how to achieve what you want me to achieve. I tried to amend it but I couldn't find the answer. If I go to the other pull request and press amend it shows me the file I already amended. Is there some information somewhere that I can follow?
I assume that is all possible via the browser?
To do it by the browser do it EXACTLY as you did it here but on your own
branch
On 20 April 2016 at 19:29, uglyeoin notifications@github.com wrote:
I assume that is all possible via the browser?
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#10014 (comment)
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
As this is only for the beez template I assume that really what you meant to do was to ADD it to your existing pull request and not to create a brand new one.
When you are using github.com to create a pull request you do not need to create a new PR for each individual file that you are editing. Once you have made your first edit then github will have created a branch in your own fork of joomla. If you then switch to use that then any changes made to that branch will be added to your first pull request