? Success

User tests: Successful: Unsuccessful:

avatar uglyeoin
uglyeoin
20 Apr 2016

Pull Request for Issue # .

Summary of Changes

added the class art-featured to featured articles in category blog view

Testing Instructions

Create a featured leading article & intro article, then create non-featured articles for leading / intro. See if the class art-featured appears on the featured articles only.

avatar uglyeoin uglyeoin - open - 20 Apr 2016
avatar uglyeoin uglyeoin - change - 20 Apr 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Apr 2016
Labels Added: ?
avatar brianteeman
brianteeman - comment - 20 Apr 2016

As this is only for the beez template I assume that really what you meant to do was to ADD it to your existing pull request and not to create a brand new one.

When you are using github.com to create a pull request you do not need to create a new PR for each individual file that you are editing. Once you have made your first edit then github will have created a branch in your own fork of joomla. If you then switch to use that then any changes made to that branch will be added to your first pull request

avatar uglyeoin
uglyeoin - comment - 20 Apr 2016

You are entirely right. Is there a way for me to make this change now?

avatar brianteeman
brianteeman - comment - 20 Apr 2016

Do it as I described. Your original Pull Request will show the nam of the branch on your own repo that you need to edit.

Closing this here

avatar brianteeman brianteeman - change - 20 Apr 2016
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-04-20 18:18:43
Closed_By brianteeman
avatar brianteeman brianteeman - close - 20 Apr 2016
avatar brianteeman brianteeman - close - 20 Apr 2016
avatar uglyeoin
uglyeoin - comment - 20 Apr 2016

Does that mean I need to go to the other branch and amend the files there?

avatar brianteeman
brianteeman - comment - 20 Apr 2016

yes that is what I wrote

On 20 April 2016 at 19:19, uglyeoin notifications@github.com wrote:

Does that mean I need to go to the other branch and amend the files there?


You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub
#10014 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar rdeutz
rdeutz - comment - 20 Apr 2016

@uglyeoin all commits to the branch will show up in the PR, amend might not work

avatar brianteeman
brianteeman - comment - 20 Apr 2016

@rdeutz it does ;)

avatar rdeutz
rdeutz - comment - 20 Apr 2016

@brianteeman it only works for me when I haven't push something to a remote repo, anyway, can be me

avatar uglyeoin
uglyeoin - comment - 20 Apr 2016

I am still unsure as to how to achieve what you want me to achieve. I tried to amend it but I couldn't find the answer. If I go to the other pull request and press amend it shows me the file I already amended. Is there some information somewhere that I can follow?

avatar rdeutz
rdeutz - comment - 20 Apr 2016
  • check out the other branch
  • copy the file you have changed here into the brach
  • commit
  • push
avatar uglyeoin
uglyeoin - comment - 20 Apr 2016

I assume that is all possible via the browser?

avatar brianteeman
brianteeman - comment - 20 Apr 2016

To do it by the browser do it EXACTLY as you did it here but on your own
branch

On 20 April 2016 at 19:29, uglyeoin notifications@github.com wrote:

I assume that is all possible via the browser?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#10014 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar uglyeoin
uglyeoin - comment - 20 Apr 2016

image

That is my branch right? And I have made the changes there, so I've done the right thing?

It is set to "patch 3" as the branch. Is that right, or should it be staging or something else?

I really struggle to find my own branch... :|

avatar brianteeman
brianteeman - comment - 20 Apr 2016

Patch 3 is THIS branch but you want to be making the change to your original PR(10011) which in this case is your staging branch

o9e9

cejo

Add a Comment

Login with GitHub to post a comment