[#10012] - [com_users] groups view: Add enabled/disabled users counting
- Fixed in Code Base
- 21 Apr 2016
- Medium
- Build: staging
- # 10012
- Diff
- andrepereiradasilva:com_users_groups-users-count
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Improvement.
Summary of Changes
This PR, as done in many other views, adds enabled/disabled users counting with links to com_users groups view.
Also:
- Minor code style changes
- Makes the delete validation js more portable (no php vars)
- Adds missing no wraping columns
Before PR
After PR
Testing Instructions
- Use latest staging and apply this patch
- Go to "Users" -> "Groups"
- Test the users countings for each group
- Also create a group and assigna a user to that group, then try to delete that group. First js warning say yes, the second js say no and check the group is not deleted.
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
?
|
||
| Title |
|
||||||
| Title |
|
||||||
| Category | ⇒ | Components UI/UX |
| Labels | |||
I have tested this item 
successfully on 0c6a9e3
thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10012.
@andrepereiradasilva could you have a look at increasing the column width please or something to increase the space between the count and the ID. Maybe its just a trick of the mind on a large screen as there are no other columns but they look very close together
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10012.
This PR has received new commits.
CC: @brianteeman, @MATsxm
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10012.
better?
If ok, no need to test again, just changed the columns titles
No not really. Adding the title would not be consistent with the other views
I was thinking more like changing the width from 1% to something like 5%
But maybe its just me
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10012.
No not really. Adding the title would not be consistent with the other views
Yes it would. See the menus view.
ah
On 21 April 2016 at 11:11, andrepereiradasilva notifications@github.com
wrote:
No not really. Adding the title would not be consistent with the other
viewsYes it would. See the menus view.
[image: image]
https://cloud.githubusercontent.com/assets/9630530/14705501/cda1cce6-07b1-11e6-8bc1-ee37af2be2c2.png—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#10012 (comment)
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
BTW on mobile view the titles dissapear
I have tested this item successfully on 6c9eeac
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10012.
OK - I will shut up and say thanks for the latest change ;)
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10012.
ok i detected a problem in the counting, need to make some changes. sorry
This PR has received new commits.
CC: @brianteeman, @MATsxm
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10012.
@brianteeman @MATsxm can you just retest the count of users part
Put two or more users in the same group and the same state and check if now the count is correct.
Will do tonight
I have tested this item successfully on 2c6d35c
Everything looks ok here, also with the counting system...
Thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10012.
I have tested this item successfully on 2c6d35c
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10012.
| Status | Pending | ⇒ | Ready to Commit |
| Labels | |||
| Milestone |
Added: |
||
| Labels |
Added:
?
|
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-04-21 19:19:48 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
| Milestone |
Removed: |
||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
| Labels |
Removed:
?
|
||
I have tested this item
successfully on 0c6a9e3
Tested ok but it seems a bit squashed and tight on the right hand side as shown in your screenshots
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10012.