Failure

User tests: Successful: Unsuccessful:

avatar astridx
astridx
4 Nov 2017

Pull Request for Issue #360.

Summary of Changes

I have made the language strings more accurate to the float option for the images and inserted dividing lines.
The dividing lines should make it clearer that the float values are not part of the icons.
I use this new language strings in the config.xml (param) and in the weblink.xml (option of the weblink). So we do not need the general language string any more.
(By the way I added the option showon="save_history:1", so that the version limit field is only shown if versions are active.)

Testing Instructions

Open the global configuration for web links (JOOMLA/administrator/index.php?option=com_config&view=component&component=com_weblinks) and see the new language strings.
After that create a new web link and see the strings in the images tab.

avatar astridx astridx - open - 4 Nov 2017
avatar franz-wohlkoenig franz-wohlkoenig - test_item - 4 Nov 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 4 Nov 2017

I have tested this item successfully on dce1d99


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/weblinks/376.

avatar astridx astridx - change - 4 Nov 2017
Title
changedlanguagestringssothatimagefloatismoreconcrete
Changed language strings so that the parameter "image float" in the config is more concrete
avatar astridx astridx - change - 4 Nov 2017
Title
changedlanguagestringssothatimagefloatismoreconcrete
Changed language strings so that the parameter "image float" in the config is more concrete
avatar astridx astridx - edited - 4 Nov 2017
avatar yvesh yvesh - reference | ffc012d - 6 Nov 17
avatar yvesh yvesh - merge - 6 Nov 2017
avatar yvesh yvesh - close - 6 Nov 2017
avatar yvesh yvesh - change - 6 Nov 2017
Status New Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-11-06 11:54:08
Closed_By yvesh
avatar yvesh yvesh - close - 6 Nov 2017
avatar yvesh yvesh - merge - 6 Nov 2017
avatar yvesh
yvesh - comment - 6 Nov 2017

Thank you @astridx!

Add a Comment

Login with GitHub to post a comment