[#377] - Make tool bar filter fields nice and multiple
- Closed
- 18 Aug 2021
- Medium
- Build: master
- # 377
- Diff
- astridx:nicetoolbar
- Failure continuous-integration/travis-ci/pr The Travis CI build failed Details
User tests: Successful: Unsuccessful:
Summary of Changes
The filter fields in the tool bar are multiple now.
Testing Instructions
Open the web links component in the back end. The filter fields are looking like in the next picture.
Apply the patch and open the web links component in the back end again. Now the filter fields are multiple and look like in the next picture.
Please also test if the fields are still working properly by testing different selection combinations
@franz-wohlkoenig Thank you very much for testing :)
and sorry, I must have forgotten to activate the error reporting. Otherwise I have no explanation for not seeing this :)
But now this should be fixes.
I have tested this item
Installing PR got:
You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'GROUP BY a.id, l.title, l.image, uc.name, ag.title, c.title ORDER BY a.title ASC' at line 10 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'GROUP BY a.id, l.title, l.image, uc.name, ag.title, c.title ORDER BY a.title ASC' at line 10
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/weblinks/377.
@franz-wohlkoenig Thank you for testing. Can you tell me when exactly this message appeared?
Message come up after calling administrator/index.php?option=com_weblinks
@franz-wohlkoenig Thank you for testing. I just made some tests and I do not see a sql error.
There have been much changes since May. So I have just created an installable web links file of my current branch.
It would be much more meaningful if someone else would create this. As I do not expect that, I put the file here once.
@franz-wohlkoenig
If you like, you can install web links with this file and redo the test. pkg-weblinks-current.zip
Installation works, but Warning: JInstaller: :Install: File does not exist /Applications/MAMP/htdocs/3/tmp/install_5a02a1cea37f6/install_5a02a1ceabfd7/media/js
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/weblinks/377.
@franz-wohlkoenig Thank you very much for testing.
This zip is for Test of all PRs?
For your information: The uploaded zip is the version form 2. November after merging #317 and #349
But I forgot this #372 - that is why you saw the error while installing
@franz-wohlkoenig AFAIK there is no nightly Build for web links.
@ALL I think it is on the time to create a new release. I never did this before. I see the button "Draft a new release", so I think I have the rights for doing this. Should I do this?
Folks, I think we should first release a beta as an installable .zip to test things.
Then, we have to add the correct ini strings to J core
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-08-18 10:19:56 |
| Closed_By | ⇒ | astridx |
I have tested this item? unsuccessfully on 6687454
Using Pull Request got Notice (different Lines depend on used Filter):
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/weblinks/377.