[#375] - Improved the Batch view of com_weblinks
- Fixed in Code Base
- 12 Feb 2018
- Medium
- Build: master
- # 375
- Diff
- astridx:marginformodal
- Failure continuous-integration/travis-ci/pr The Travis CI build failed Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #367.
Summary of Changes
I changed the batch view of com_weblinks analogously to the batch view of com_content.
Testing Instructions
- Create a few weblinks via com_weblinks (Components | Web Links).
- Select all this weblinks and click the toolbar button batch
- See that the view has a nice margin.
- Please also check that the component is still working correctly. For example: Move weblinks to another category or change the tags.
@franz-wohlkoenig Thank you for testing so reliable.
I tried to adjust your error message. For me, the view is without error. It should look like this:
Or the column associations should be empty, if there is no association.
My first idea:
Line 152 of the file JOOMLA/administrator/components/com_weblinks/views/weblinks/tmpl/default.php need the variable associations. This variable was introduced in this PR a few days ago:
#349
Could it be, that this PR is not merged well in your testing installation? How did you update your system?
I use pkg-weblinks-3.7.0-beta1.zip. I can download it once more an test again if you say so.
Using Branch "Master" or "Test": Install failed.
@franz-wohlkoenig I'm not sure, but I think pkg-weblinks-3.7.0-beta1.zip only includes changes made before May (https://github.com/joomla-extensions/weblinks/releases).
@ALL Are I am right? Does any one know if there is a nighly build for web links?
I think so too but didn't find a actual Source.
@franz-wohlkoenig If you like you can try with the source I uploaded here a few minutes ago: #377
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/weblinks/375.
@franz-wohlkoenig Thank you very much for testing.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/weblinks/375.
| Status | New | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-02-12 22:58:05 |
| Closed_By | ⇒ | yvesh |
I have tested this item? unsuccessfully on 5889e02
Modal without PR:
Modal with PR:
But at Weblinks-View:
i guess this don't depends on PR, to be sure i marked as unsuccessfully.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/weblinks/375.