User tests: Successful: Unsuccessful:
Change latest copyright year with tag for automatic substitution by the build script.
Run build script and check that all files have the correct copyright date in them.
This might be stupid but we have __DEPLOY_VERSION__
and then ##YEAR##
, so me thinking why different notation?
@dgt41 different history.. ##YEAR##, ##VERSION##
etc. is some years older then @andrepereiradasilva __DEPLOY_VERSION__
.
You would need to ask him, why he choose that syntax ;-)
But it's a good idea to standardize these things too.
We started using the deploy version placeholder on the Framework in
2013/2014 and it gets replaced by our Jenkins job that handles git tags.
So that's its history.
On Saturday, September 24, 2016, Yves Hoppe notifications@github.com
wrote:
@dgt41 https://github.com/dgt41 different history.. ##YEAR##,
##VERSION## etc. is some years older then @andrepereiradasilva
https://github.com/andrepereiradasilva DEPLOY_VERSION.You would need to ask him, why he choose that syntax ;-)
But it's a good idea to standardize these things too.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#243 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWfoa8Q41gKUHMNvvgGZ4gAfxYzavtcks5qtOEwgaJpZM4JIfEw
.
when created the bump.php version script (https://github.com/joomla/joomla-cms/blob/staging/build/bump.php) on the CMS i followed the same principle as the framework , ie, use __DEPLOY_VERSION__
Later added the automatic year change in copyright also in the cms on script build without the need for a varible (just preg_replace).
https://github.com/joomla/joomla-cms/blob/staging/build/bump.php#L307
Closing as this is not the right approach.
@chrisdavenport That is not supported in the current JoRobo version. Currently the automatic substitution is only done for certain files, like script.php.
But i made an PR against JoRobo adding that functionality. See here.