Failure

User tests: Successful: Unsuccessful:

avatar wderuijter
wderuijter
18 Jul 2016

After comments in #242
Now with the correction of the code in 2 places.

Summary of Changes

Get the correct target param from the item instead of the component target param

Testing Instructions

Set the weblink component to open all weblinks in 'Parent'
Set a single weblink A to open in 'New window'
See the weblink A in the module opens in 'Parent', regarding the weblink's setting
Apply this fix
See the weblink in the module respects the weblink's setting and open in 'New window'

avatar wderuijter wderuijter - open - 18 Jul 2016
avatar wderuijter wderuijter - close - 18 Jul 2016
avatar wderuijter
wderuijter - comment - 18 Jul 2016

Never mind, added it to the original PR

Add a Comment

Login with GitHub to post a comment