[#242] - Get the correct target param from the item
- Closed
- 26 Jul 2016
- Medium
- Build: master
- # 242
- Diff
- wderuijter:patch-1
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Get the correct target param from the item instead of the component target param
Testing Instructions
- Set the weblink component to open all weblinks in 'Parent'
- Set a single weblink A to open in 'New window'
- See the weblink A in the module opens in 'Parent', regarding the weblink's setting
- Apply this fix
- See the weblink in the module respects the weblink's setting and open in 'New window'
@wderuijter There are two places, where you need to fix it. Please change it in line 94 also
I have tested this item
Works as expected - Thank you :)
This comment was created with the J!Tracker Application at issues.joomla.org/weblinks/242.
@wderuijter There is a problem with the acceptance test. See the report below:
1) AdministratorCategoriesCest: Test category edit view tabs
Test tests/acceptance/administrator/AdministratorCategoriesCest.php:administratorVerifyAvailableTabs
Step Verify available tabs ["Category","Publishing","Permissions","Options"]
Fail - Expected | + Actual
@@ @@
Array (
0 => 'Category'
1 => 'Publishing'
2 => 'Permissions'
3 => 'Options'
1 => 'Options'
2 => 'Publishing'
3 => 'Permissions'
)
Scenario Steps:
$I->verifyAvailableTabs(["Category","Publishing","Permissions","Options"]) at tests/acceptance/administrator/AdministratorCategoriesCest.php:188
$I->waitForText("Web Links: New Category","30",{"css":"h1"}) at tests/acceptance/administrator/AdministratorCategoriesCest.php:187
$I->clickToolbarButton("New") at tests/acceptance/administrator/AdministratorCategoriesCest.php:186
$I->amOnPage("administrator/index.php?option=com_categories&extension...") at tests/acceptance/administrator/AdministratorCategoriesCest.php:185
// I am going to Navigate to Categories page in /administrator/ and verify the Tabs
$I->doAdministratorLogin() at tests/acceptance/administrator/AdministratorCategoriesCest.php:182
The order of the options is different, so this needs to be rectified. Can you have a look at it?
I have tested this item✅ successfully on 3fc4d98
This comment was created with the J!Tracker Application at issues.joomla.org/weblinks/242.