Feeling Lucky
[#227] - Running phpcs check with travis on php 5.6
- Closed
- 2 Aug 2016
- Medium
- Build: master
- # 227
- Diff
- yvesh:phpcs
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Summary of Changes
Adding phpcs checks (with joomla rules) to .travis.yml.
As in Joomla! core phpcs is only run with PHP 5.6. They run after the system tests and.
Testing Instructions
Look at the result of the travis log for PHP 5.6
zero-24
- comment
- 1 Aug 2016
Can you sync this again with my last PR included?
zero-24
- comment
- 1 Aug 2016
Hehe :)
zero-24
- comment
- 1 Aug 2016
Hmm i'm sure this should be fixed. I can have a look on it tomorrow :)
zero-24
- comment
- 1 Aug 2016
Btw. it is just the last travis mention :P the xml files are bad too ;)
yvesh
- comment
- 2 Aug 2016
@zero-24 Hey you made it Tobias! Green!! Thank you :-)
// Please merge @puneet0191 @javigomez @chrisdavenport
zero-24
- comment
- 2 Aug 2016
Looks good. I can have a look into the cs issues later this week. If not someone is faster than me ;)