@yvesh what is about the mysql versions (client & server) that can't handle uft8mb4?

see: https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_admin/script.php#L1684-L1805

as well as: https://github.com/joomla/joomla-cms/blob/staging/libraries/joomla/database/driver/mysqli.php#L954

@zero-24 you are right. Already suppressed that mess from my memories.. :-) Going to update the PR to check that in the script.php before..

You don't need to do this as a complex conditional in your PHP update script. You can make it a regular SQL schema update and since the MySQL drivers downgrade gracefully from utf8mb4 to utf8 if the former's support isn't there you don't need to do any conditionals around things.

See BabDev/Podcast-Manager@39e8904 for how I did it in an extension.

@mbabker That's what i did before until @zero-24 complained.. Then i revert it back.. :)

The core does it in a massively complex way for reasons I never fully grasped or paid attention to. At an extension level, if you have to do it with PHP scripts then you're doing something majorly wrong.

Ok sorry I don't know that behaviors in the MySQL servers.

Okay reverted back to initial version

I have tested this item ✅ successfully on c6821b0

New install and upgrade both work correctly.

Thanks, I install the package its work correctly.

I have tested this item ✅ successfully on c6821b0

What will happen if a < 3.6.0 site updates weblinks with a change to utf8mb4 ?

Technically this would only be valid against a Joomla 3.5 or later install. So an install script and the update server definition should limit presenting this update to only those versions (i.e. Joomla 3.4 shouldn't be able to update to it).

Okay if you want i go and change that a third time (had that check already in script.php..).

@mbabker @chrisdavenport @infograf768 Any plans for how long Weblinks should support < 3.5.0 installs?

It shouldn't have to.

So all we need to do is bump the version requirement in the XML files to 3.5 then?

Please @yvesh update your pull with latest master to see if Travis passes this time.

Thanks

@javigomez Done, passing now :)

This PR has received new commits.

CC: @chrisdavenport, @pritalpatel

This PR has received new commits.

CC: @chrisdavenport, @pritalpatel

I have tested this item ✅ successfully on 5cbb43d

I have tested this item ✅ successfully on 5cbb43d