Pending

User tests: Successful: Unsuccessful:

avatar roland-d
roland-d
12 Jul 2014

If there are any errors with the environment, for example OpenSSL is not activated, patchtester now throws a fatal error or WSOD. This patch fixes this by presenting the user with the actual error message.

avatar roland-d roland-d - open - 12 Jul 2014
avatar mbabker mbabker - close - 9 May 2015
avatar mbabker
mbabker - comment - 9 May 2015

The errors I'm pretty sure were because the check in the layout came after trying to get data from $this->state which isn't initialized if there are errors. Moved the check up, this should be resolved.

avatar roland-d
roland-d - comment - 12 May 2015

Well, that didn't do it. When I disable OpenSSL, the list of issues is retrieved from GitHub but when I close the modal the content body stays empty. Refreshing the page won't just the list of items. Enabling OpenSSL makes the list appear.

avatar roland-d roland-d - reopen - 12 May 2015
avatar mbabker
mbabker - comment - 12 May 2015

There was a bug with the error template not rendering. If OpenSSL is disabled, you shouldn't even have a fetch button in the toolbar. The issue list is now stored in the database, so it's expected you'd still have an issue list (but you should never see it unless you're snooping in the database as the error checks block you from seeing the list).

avatar roland-d
roland-d - comment - 9 Jun 2015

@mbabker Just testing this issue again with Patchtester 2.0.0beta3. Having openSSL disabled I am just shown a blank page and only the Options button. Would be nice to render a message as to why the page is blank :)

avatar mbabker
mbabker - comment - 9 Jun 2015

It's fixed at cbb1652 (after the last release tag).

avatar roland-d roland-d - close - 9 Jun 2015
avatar roland-d
roland-d - comment - 9 Jun 2015

Perferct. Closing this PR.

avatar roland-d roland-d - change - 9 Jun 2015
Status New Closed
Closed_Date 2015-05-09 17:18:38 2015-06-09 20:13:31
Closed_By roland-d
Build master
avatar roland-d roland-d - close - 9 Jun 2015
avatar roland-d roland-d - head_ref_deleted - 9 Jun 2015

Add a Comment

Login with GitHub to post a comment