User tests: Successful: Unsuccessful:
If there are any errors with the environment, for example OpenSSL is not activated, patchtester now throws a fatal error or WSOD. This patch fixes this by presenting the user with the actual error message.
Well, that didn't do it. When I disable OpenSSL, the list of issues is retrieved from GitHub but when I close the modal the content body stays empty. Refreshing the page won't just the list of items. Enabling OpenSSL makes the list appear.
There was a bug with the error template not rendering. If OpenSSL is disabled, you shouldn't even have a fetch button in the toolbar. The issue list is now stored in the database, so it's expected you'd still have an issue list (but you should never see it unless you're snooping in the database as the error checks block you from seeing the list).
Perferct. Closing this PR.
Status | New | ⇒ | Closed |
Closed_Date | 2015-05-09 17:18:38 | ⇒ | 2015-06-09 20:13:31 |
Closed_By | ⇒ | roland-d | |
Build | ⇒ | master |
The errors I'm pretty sure were because the check in the layout came after trying to get data from
$this->state
which isn't initialized if there are errors. Moved the check up, this should be resolved.