Success

User tests: Successful: Unsuccessful:

avatar richard67
richard67
10 Apr 2020

Pull Request for Issues #265 and #263 .

Summary of Changes

  • Remove language code prefix, e.g. "en-GB." from name of language files like it was done for the CMS in the 4.0-dev branch.
  • Copy the COM_PATCHTESTER_XML_DESCRIPTION string from .sys.ini to .ini.
  • Alpha order the new sting COM_PATCHTESTER_PATCH_BREAKS_SITE to the right place in the en-GB file.
  • Copy the same new sting to the en-US file.
  • Translate the same new string to German and add it to the de-DE file.

Testing Instructions

Install following patch tester 4 rc-1 package patched with the modifications of this Pull Request (PR): https://test5.richard-fath.de/com_patchtester_4.0.0.rc2_pr-268.zip on a Joomla 4 nightly build or current 4.0-dev branch.

Check that patchtester works without any language string problems which were not there without this PR.

avatar richard67 richard67 - open - 10 Apr 2020
avatar richard67
richard67 - comment - 10 Apr 2020

@roland-d Please ask the translators to check if my changes in crowdin.yaml are ok.

avatar richard67 richard67 - change - 10 Apr 2020
The description was changed
avatar richard67 richard67 - edited - 10 Apr 2020
avatar richard67 richard67 - change - 10 Apr 2020
The description was changed
avatar richard67 richard67 - edited - 10 Apr 2020
avatar richard67 richard67 - change - 10 Apr 2020
Title
Remove language code prefix like "en-GB." from language files' names for Joomla 4
Remove language code prefix like "en-GB." from language files' names for Joomla 4 and other language file fixes
avatar richard67 richard67 - edited - 10 Apr 2020
avatar richard67 richard67 - change - 10 Apr 2020
Title
Remove language code prefix like "en-GB." from language files' names for Joomla 4
Remove language code prefix like "en-GB." from language files' names for Joomla 4 and other language file fixes
avatar richard67
richard67 - comment - 10 Apr 2020

@Bakual Could you have a look if the changes for crowdin.yaml in this PR here are correct?

avatar Bakual
Bakual - comment - 10 Apr 2020

As I'm not involved with the Patchtester project on Crowdin I don't really know. You will have to check with the sync tool that is set up - I think it doesn't use the Crowdin GitHub integration but some other script.

avatar richard67
richard67 - comment - 10 Apr 2020

@roland-d At this point I am out, I don't know anything about any sync tool.

avatar roland-d roland-d - change - 11 Apr 2020
Milestone Added: 4.0.0
avatar roland-d roland-d - change - 11 Apr 2020
Status New Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-04-11 19:37:43
Closed_By roland-d
avatar roland-d roland-d - close - 11 Apr 2020
avatar roland-d roland-d - merge - 11 Apr 2020
avatar roland-d roland-d - reference | f1d7183 - 11 Apr 20
avatar roland-d roland-d - merge - 11 Apr 2020
avatar roland-d roland-d - close - 11 Apr 2020
avatar richard67 richard67 - head_ref_deleted - 11 Apr 2020

Add a Comment

Login with GitHub to post a comment