avatar astridx
astridx
8 Apr 2020

Steps to reproduce the issue

  1. Install Patch tester and use Credentials in the options for GitHub Authentication
    Joomla  Patch Tester Settings   test   Administration

  2. Try to fetch patches and see, that this is not working. (Fetch patches via GitHub Authentication set to Token is working)

  3. Try to apply a patch with GitHub Authentication set to Credentials. It is not possible to do this. You see an error containing your password. (Apply patches via GitHub Authentication set to Token is working)
    Joomla  Patch Tester   test   Administration

avatar astridx astridx - open - 8 Apr 2020
avatar astridx astridx - change - 8 Apr 2020
The description was changed
avatar astridx astridx - edited - 8 Apr 2020
avatar astridx astridx - change - 8 Apr 2020
The description was changed
avatar astridx astridx - edited - 8 Apr 2020
avatar astridx astridx - change - 8 Apr 2020
The description was changed
avatar astridx astridx - edited - 8 Apr 2020
avatar roland-d
roland-d - comment - 11 Apr 2020

Hello @astridx Does your password have a @ in it? That would be a known issue and later this year the username/password will be removed from the Patch Tester because GitHub is going to remove that as well.

So the advice is to always use the token.

avatar astridx
astridx - comment - 11 Apr 2020

Thank you Roland.

I use the token. So for me it is OK.

I only want to tell you, that there is (maybe) a problem with the credentials method.

No, there is no @ in my password.

avatar roland-d
roland-d - comment - 11 Apr 2020

@astridx There are some known issues with the password credentials, especially if you have special characters in them. The code tend to choke on it :)

Thank you for reporting this, since GitHub is going to pull the plug on passwords I won't be fixing this.

avatar roland-d roland-d - change - 11 Apr 2020
Status New Closed
Closed_Date 0000-00-00 00:00:00 2020-04-11 20:11:30
Closed_By roland-d
avatar roland-d roland-d - close - 11 Apr 2020

Add a Comment

Login with GitHub to post a comment