avatar ChristineWk
ChristineWk
19 Oct 2019

Steps to reproduce the issue

see screenshot

Expected result

Actual result

System information (as much as possible)

see screenshot

Additional comments

tool-tip-problem

avatar ChristineWk ChristineWk - open - 19 Oct 2019
avatar uglyeoin
uglyeoin - comment - 26 Oct 2019
:focus + [role="tooltip"], :hover + [role="tooltip"] {
    display: block;
    position: absolute;
    bottom: 0;
}

This can be fixed by adding bottom: 0; to /administrator/templates/atum/css/template.min.css?f6da6cc9d583349709a7026265890f4d

I'm not sure if this is a pull request I can do. I'm not sure that is the right place to do it either as it would affect all other tooltips. However, as a solution to solve @ChristineWk issue you can do it in Inspect Element

image

avatar ChristineWk
ChristineWk - comment - 26 Oct 2019

@uglyeoin

Thank you for your investigation. Found via inspector required code, tried/added temporary the bottom: 0; accordingly - but no success. Think, the reason might be that it's template.min.css compiled css. Maybe I should try directly in that CSS?

Also I don't know whether it affect other tool-tips.

avatar uglyeoin
uglyeoin - comment - 28 Oct 2019

You added it to this rule?

:focus + [role="tooltip"], :hover + [role="tooltip"] {

It shouldn't matter if it is the compiled file as you are using the browser so it is not reloading it at that point. If it isn't working perhaps you could add !important just to make sure your rule is taking precedent. It worked for me though, see my screenshot for how I achieved it.

avatar mangeshmane mangeshmane - reference | eb5f87b - 2 Nov 19
avatar richard67
richard67 - comment - 9 Nov 2019

Please test #246 .

avatar richard67
richard67 - comment - 9 Nov 2019

I've just tested. #246 is correct and fixes this issue. So I think this issue could be closed.

avatar ChristineWk
ChristineWk - comment - 9 Nov 2019
avatar richard67
richard67 - comment - 9 Nov 2019

I have installed patchtester Patch Tester 4.0.0 Beta 2 on a clean, current 4.0-dev branch of the CMS, then I have applied the changes from PR's #241 and #242 "manually", i.e. by editing the php files changed by these PR's, in order to make PT work. Then I've verified that I have this issue. Then I've applied the change in #246 , also "manually", and verified the issue has gone.

avatar richard67
richard67 - comment - 9 Nov 2019

In addition I have verified that in other list views of the cms, the same scheme for the tool tip div's ID is used as it is after the correction made by PR #246. A lot easier it is just to apply the change done by PR #246 in the developer tools of your browser by using "Examine element" ("Element untersuchen" in German FireFox) and then just editing the id like that PR changes it and then check the result.

avatar ChristineWk
ChristineWk - comment - 9 Nov 2019

Tried both. Changed accordingly: eb5f87b
Via Developer tools FF (no success) and also directly via FTP above File. Hover OK, but not when clicking in box.

avatar richard67
richard67 - comment - 9 Nov 2019

Strange. Anyway, it is correct.

Trust me (said the Transsilvanian cab driver to the scared British tourist on the way to that spooky castle ;-) ).

avatar ChristineWk
ChristineWk - comment - 9 Nov 2019

Of course, I trust you :-) Forever and ever (it's a song)

avatar uglyeoin
uglyeoin - comment - 11 Nov 2019

I'm confused, it says Hackwar has merged the other two pulls. Does that mean they are now closed? So long as we use the latest version of Patchtester we don't need to do that part just test the final part?

avatar richard67
richard67 - comment - 11 Nov 2019

PR's #241 and #242 have been merged, but no new beta release has been built after that, and so if using the latest beta "4.0.0 Beta 2" it still needs to apply those PR's, too.

avatar richard67
richard67 - comment - 11 Nov 2019

P.S.: For testing the PR #246 for this issue you don‘t need the other 2 PR‘s, you need them only if you want to use patchtester to apply and revert PR‘s.

avatar ChristineWk
ChristineWk - comment - 11 Nov 2019

I'm also confused. (via FTP manually) Days before I hv changed accordingly: mangeshmane@eb5f87b

Just now in addition: 380831c & 63d9019

avatar richard67
richard67 - comment - 11 Nov 2019

@ChristineWk Ah I just see you wrote hover is ok, only clicking in the box is not? I have to test again tonight after work... maybe I‘ve tested only hovering.

avatar richard67
richard67 - comment - 11 Nov 2019

@ChristineWk I've just tested again, it works for me with hover and also when cursor is in the search box. See screen shot.
patchtester-search-box-tool-tip

avatar richard67
richard67 - comment - 11 Nov 2019

Maybe the difference is that I test on current 4.0-dev branch of the CMS and not any older alpha or nightly build?

avatar richard67
richard67 - comment - 11 Nov 2019

Here is a link to a patched install package for the patchtester which contains all recently merged changed plus the change from PR #246 (plus the change of my new PR #249, but this should not havy any impact on the tool tip): https://test5.richard-fath.de/com_patchtester_4.0.0.beta3-dev-3.zip

Install this on a clean 4.0dev of the CMS or a nightly build of last night. Clean means not updated from any alpha because this is not supported yet, and also don't update the patchtester but make a new installation of it.

avatar ChristineWk
ChristineWk - comment - 11 Nov 2019

@richard67
What I'm currently use is this:

Joomla! Patch Tester | Administrator | Component | 4.0.0-beta2 | 17-October-2019
Site | File | No Problems | 4.0.0-2019-10-06 | ‎4.0.0-beta1-dev

So, I will delete the space and install everything new ..... But it will takes time :-)
Thanks for help.

avatar ChristineWk
ChristineWk - comment - 11 Nov 2019

So, completely new full package nightly build of last night.
Also installed your .../com_patchtester_4.0.0.beta3-dev-3

System shows:

Site | File | No Problems | 4.0.0-2019-10-17 | ‎4.0.0-beta1-dev
Administrator | Component | No Problems | 4.0.0 | ‎4.0.0-beta2

I'm proudly present :-)

patchtester_beta3

avatar richard67
richard67 - comment - 11 Nov 2019

So all ok? If so, you can close this issue.

avatar richard67
richard67 - comment - 11 Nov 2019

And if ok, could you also comment in PR #246 that you have tested with success?

avatar ChristineWk
ChristineWk - comment - 11 Nov 2019

yes OK, will check PR #246.

avatar richard67
richard67 - comment - 11 Nov 2019

PR #246 was included in my zip so you have tested it already.

avatar richard67
richard67 - comment - 11 Nov 2019

@ChristineWk Finally you can close this issue. There should be a button for this on GitHub for you in issues which you have created. Best is closing with a comment "solved with PR #246".

avatar ChristineWk
ChristineWk - comment - 11 Nov 2019

Solved with PR #246

avatar ChristineWk ChristineWk - change - 11 Nov 2019
Status New Closed
Closed_Date 0000-00-00 00:00:00 2019-11-11 21:58:56
Closed_By ChristineWk
avatar ChristineWk ChristineWk - close - 11 Nov 2019
avatar ChristineWk ChristineWk - close - 11 Nov 2019
avatar richard67
richard67 - comment - 11 Nov 2019

Perfect.

Add a Comment

Login with GitHub to post a comment