Feeling Lucky
[#242] - [4.0] Fix applying patches failing on Linux hosts
- Fixed in Code Base
- 24 Oct 2019
- Medium
- Build: 4.0-dev
- # 242
- Diff
- richard67:patch-2
- Success continuous-integration/drone/pr Build is passing Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #240 .
Summary of Changes
Use DIRECTORY_SEPARATOR for expode and implode of the path to files to be backed up so that later creating the directories for the backups doesn't fail.
I don't know if this is the right way to fix it, but it works here.
Testing Instructions
See issue #240 .
richard67
- comment
- 22 Oct 2019
Sorry, my previous post was in German first by accident. Have changed it to Englisdh yesterday. Unfortunately still no reaction. So the Patchtester 4 with CI enabled is not usable on Linux or other Unixoids. What a pity.
Hackwar
- | Status | New | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-10-24 11:55:25 |
| Closed_By | ⇒ | Hackwar |
@Hackwar If you don't like
DIRECTORY_SEPARATORwe might have to use'/'? If so, let me know here and I'll change this PR.P.S.: Unfortunately I don't have a Windows test system. Someone should test if
'/'orDIRECTORY_SEPARATORworks on Windows, too.