Success

User tests: Successful: Unsuccessful:

avatar photodude
photodude
22 Dec 2017

Pull Request for Issue code was unnecessarily multiline

Summary of Changes

Reduce code to a single line

Testing Instructions

Code review should be sufficient.

avatar photodude photodude - open - 22 Dec 2017
avatar N6REJ
N6REJ - comment - 25 Dec 2017

Maybe change line 379 just to make it cleaner at the same time?
. '<jdoc:include type="modules" name="position-0" style="none" />' . "\n\t</div>\n";

avatar photodude
photodude - comment - 26 Dec 2017

@N6REJ I think 378-379 has to be done with these "escape characters" because they are used in the str_replace() at line 382

avatar wilsonge wilsonge - change - 17 Feb 2018
Status New Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-02-17 23:06:34
Closed_By wilsonge
avatar wilsonge wilsonge - close - 17 Feb 2018
avatar wilsonge wilsonge - merge - 17 Feb 2018
avatar wilsonge wilsonge - reference | fe92b46 - 17 Feb 18
avatar wilsonge wilsonge - merge - 17 Feb 2018
avatar wilsonge wilsonge - close - 17 Feb 2018
avatar photodude photodude - head_ref_deleted - 18 Feb 2018

Add a Comment

Login with GitHub to post a comment