GitHub sync enhancement Failure

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
24 Jul 2017

Pull Request for Issue #885 .

Summary of Changes

Some work on receiving the webhook for pull request reviews. I'm deliberately leaving doing the UI for this as a separate PR, so we can at least be storing the data whilst we are working on the interface

TODO

  1. Test it on a live service - I haven't figured out fully integrating this yet (EDIT: DONE)
  2. I'm unsure if we get a hook on the COMMENT state documented in the API (https://developer.github.com/v3/pulls/reviews/#submit-a-pull-request-review) or not (EDIT: We did - see #1009)
  3. Do we want to save in the activities table who modified a review? (EDIT: We don't recieve who modified a review in the hook data -_- )
  4. In the case of dismissing a comment from the docs alone I couldn't work out where the associated dismissed message was stored (if it is) (EDIT: It's not - neither is the author who dismissed)
  5. I wasn't sure whether the comments need to be stored as text rather than a varchar(500)
avatar wilsonge wilsonge - open - 24 Jul 2017
avatar wilsonge wilsonge - change - 24 Jul 2017
The description was changed
avatar wilsonge wilsonge - edited - 24 Jul 2017
avatar wilsonge wilsonge - change - 24 Jul 2017
The description was changed
avatar wilsonge wilsonge - edited - 24 Jul 2017
avatar wilsonge wilsonge - change - 24 Jul 2017
The description was changed
avatar wilsonge wilsonge - edited - 24 Jul 2017
avatar wilsonge wilsonge - change - 24 Jul 2017
The description was changed
avatar wilsonge wilsonge - edited - 24 Jul 2017
avatar wilsonge wilsonge - change - 24 Jul 2017
The description was changed
avatar wilsonge wilsonge - edited - 24 Jul 2017
avatar wilsonge wilsonge - change - 24 Jul 2017
The description was changed
avatar wilsonge wilsonge - edited - 24 Jul 2017
avatar wilsonge wilsonge - change - 24 Jul 2017
The description was changed
avatar wilsonge wilsonge - edited - 24 Jul 2017
avatar wilsonge
wilsonge - comment - 29 Jul 2017

@elkuku @b2z any feedback?

avatar elkuku
elkuku - comment - 30 Jul 2017

Sorry for the late response, I'm currently in the jungle (literally) without any "real" internet access...

I also have to confess that I am not (yet) familiar what those "PR review comments" really are and how they are different from "code reviews comments" or "simple comments".
I guess that they are not "code related" so I wonder what could be the difference between:

Would it make sense to add a CLI script to this PR to import already existing stuff?

Test it on a live service

I wonder if it could be possible for the Joomla! project to set up such a service with access for several individuals?
I think this would ease up the development, especially with testing stuff like webhooks.

I believe the rest of your TODOs will be solved when we have a test site ?

avatar wilsonge
wilsonge - comment - 30 Jul 2017

screen shot 2017-07-30 at 18 05 52

This is a pull request review :P and you added a comment to that review. That's the comment associated with a PR review

avatar b2z
b2z - comment - 30 Jul 2017

@wilsonge how do you see the UI? We do not have code in tracker, so we will display them as simple comments?

Looks good - needs a bunch of testing

@elkuku not much wtihout UI ?

avatar wilsonge
wilsonge - comment - 30 Jul 2017

@wilsonge how do you see the UI

I'm not sure. Because you can have multiple reviews by the same person, I assume you have to do a GitHub style on the system where you display the latest review at the bottom. Maybe in the timeline it's worth saying "XXX reviewed this Pull Request" (I'm unsure whether reviews should be hidden from the UI when they are dismissed or not)

avatar wilsonge
wilsonge - comment - 30 Jul 2017

@elkuku not much wtihout UI ?

You can test this by just looking at the database entries and webhook responses as I said above I'd rather work on the UI elsewhere because I think it can become quickly rapidly.

avatar wilsonge
wilsonge - comment - 18 Feb 2018

OK So I've tested this using the CLI hook testing tool and the sample webhook data that github have in their docs at https://developer.github.com/v3/activity/events/types/#pullrequestreviewevent and at least the submission of a webhook works. Unless @mbabker can set me up to save some hook results from the live project I think the best thing to do is to publish this and start to look at what does and doesn't break.

avatar mbabker mbabker - change - 18 Feb 2018
Status New Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-02-18 17:53:01
Closed_By mbabker
avatar mbabker mbabker - close - 18 Feb 2018
avatar mbabker mbabker - merge - 18 Feb 2018
avatar mbabker mbabker - reference | 41d2706 - 18 Feb 18
avatar mbabker mbabker - merge - 18 Feb 2018
avatar mbabker mbabker - close - 18 Feb 2018
avatar mbabker mbabker - head_ref_deleted - 18 Feb 2018
avatar mbabker
mbabker - comment - 18 Feb 2018
avatar wilsonge wilsonge - change - 18 Feb 2018
The description was changed
avatar wilsonge wilsonge - edited - 18 Feb 2018
avatar wilsonge wilsonge - change - 18 Feb 2018
The description was changed
avatar wilsonge wilsonge - edited - 18 Feb 2018
avatar wilsonge wilsonge - change - 18 Feb 2018
The description was changed
avatar wilsonge wilsonge - edited - 18 Feb 2018

Add a Comment

Login with GitHub to post a comment