User tests: Successful: Unsuccessful:
Pull Request for Issue #885 .
Some work on receiving the webhook for pull request reviews. I'm deliberately leaving doing the UI for this as a separate PR, so we can at least be storing the data whilst we are working on the interface
varchar(500)
Sorry for the late response, I'm currently in the jungle (literally) without any "real" internet access...
I also have to confess that I am not (yet) familiar what those "PR review comments" really are and how they are different from "code reviews comments" or "simple comments".
I guess that they are not "code related" so I wonder what could be the difference between:
Would it make sense to add a CLI script to this PR to import already existing stuff?
Test it on a live service
I wonder if it could be possible for the Joomla! project to set up such a service with access for several individuals?
I think this would ease up the development, especially with testing stuff like webhooks.
I believe the rest of your TODOs will be solved when we have a test site
@wilsonge how do you see the UI
I'm not sure. Because you can have multiple reviews by the same person, I assume you have to do a GitHub style on the system where you display the latest review at the bottom. Maybe in the timeline it's worth saying "XXX reviewed this Pull Request" (I'm unsure whether reviews should be hidden from the UI when they are dismissed or not)
OK So I've tested this using the CLI hook testing tool and the sample webhook data that github have in their docs at https://developer.github.com/v3/activity/events/types/#pullrequestreviewevent and at least the submission of a webhook works. Unless @mbabker can set me up to save some hook results from the live project I think the best thing to do is to publish this and start to look at what does and doesn't break.
Status | New | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-02-18 17:53:01 |
Closed_By | ⇒ | mbabker |
@wilsonge Check https://github.com/joomla/joomla-cms/settings/hooks/22200574 for live payloads.
@elkuku @b2z any feedback?