bug
avatar mbabker
mbabker
17 Feb 2017

The RTC behavior should only add/remove that specific label. Whatever is causing all other labels and the milestone to be removed needs to be corrected.

avatar mbabker mbabker - open - 17 Feb 2017
avatar zero-24
zero-24 - comment - 17 Feb 2017

https://github.com/joomla/jissues/blob/master/src/App/Tracker/Controller/Hooks/Listeners/JoomlacmsPullsListener.php#L330-L351

Maybe this is a permission problem? If you don't have the permissions to change the label / milestones than the labels / milestones got removed.

So i think this could be a problem in the save method where the milestones and labels are empty if you don't have the permissions to change them. This result than in removing them.

avatar zero-24
zero-24 - comment - 25 Feb 2017

hmm i have just noticed that the issue i'm editing does not contain any labels & milestone on the tracker

unbenannt3

But does contain some labels and milestone on github.

unbenannt2

So this looks like a bigger problem to me?

avatar b2z
b2z - comment - 14 Mar 2017

@zero-24 may be ;)
@mbabker can you please provide DB export of i.j.org to replicate the problem? AFAIK you did it something like this before in other issue. Do not remember, in which :)

avatar b2z b2z - change - 14 Mar 2017
Labels Added: bug
avatar b2z b2z - labeled - 14 Mar 2017
avatar b2z b2z - assigned - 14 Mar 17
avatar b2z
b2z - comment - 15 Mar 2017

@mbabker thanks!

@zero-24 I see that you was able to set labels and milestone. I also tried to edit this issue and it contains labels and milestones. Is it specific case for this issue or it is happening all the time?

I do not think that the permission is the issue here as we display labels only for user with manage rights.

{% if user.check('manage') %}

And this users for sure are those who has permissions. I think the problem was that this issue did not have any label and milestone on the time of your editing. Why? That is the question :)

avatar zero-24
zero-24 - comment - 15 Mar 2017

I think the problem was that this issue did not have any label and milestone on the time of your editing. Why? That is the question :)

Correct. Maybe the sync job is failing for any reason?

avatar b2z
b2z - comment - 15 Mar 2017

Maybe the sync job is failing for any reason?

Hate to say it, but it seems that it is sync job again :(

avatar zero-24
zero-24 - comment - 15 Mar 2017

@mbabker do you have any errors or similiar in the logs?

avatar mbabker
mbabker - comment - 15 Mar 2017

All the cron logging is telling me is that weblinks and the CMS jobs aren't running in full. Not much has changed since #915 or #676 were logged.

avatar b2z
b2z - comment - 24 Mar 2017

Can we close it?

avatar b2z
b2z - comment - 21 Aug 2017

@zero-24 is issue still valid?

avatar zero-24
zero-24 - comment - 21 Aug 2017

Saddly yes. When you are a user with no persmissions on gihub but just on the tracker and set a item e.g. to RTC all labels expected RTC are removed.

avatar b2z
b2z - comment - 8 Sep 2017

:( I will try to replicate and fix it.

avatar b2z
b2z - comment - 9 Nov 2017

Annoying. @mbabker can you give actual DB state from issues to import? Thank you!

Add a Comment

Login with GitHub to post a comment