Success

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
12 Feb 2017

Summary of Changes

Upgrades some of the architecture for PHP 7, including:

  • Wrapping the front controllers in JavaScript like IIFE functions, this prevents variables used in these files from leaking into the rest of the app as global variables (https://www.bram.us/2015/01/02/php-7-iife-support/ briefly covers this feature)
  • Bumps PHPUnit to 6.0
  • Bumps Symfony dependencies to the 3.x branch
  • Bumps Twig to 2.0
  • General vendor update
    • joomla/database to 1.5 (we can start using prepared statements now)
    • joomla/view is locked to the last commit before the package's dependency to joomla/model is refactored out

Testing Instructions

The app still works

avatar mbabker mbabker - open - 12 Feb 2017
avatar elkuku elkuku - close - 17 Feb 2017
avatar elkuku elkuku - merge - 17 Feb 2017
avatar elkuku elkuku - reference | 725fe34 - 17 Feb 17
avatar elkuku elkuku - merge - 17 Feb 2017
avatar elkuku elkuku - close - 17 Feb 2017
avatar elkuku elkuku - change - 17 Feb 2017
Status New Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-02-17 16:12:11
Closed_By elkuku
avatar elkuku elkuku - head_ref_deleted - 17 Feb 2017
avatar elkuku
elkuku - comment - 17 Feb 2017

I have tested this and everything seems to work ?

avatar b2z
b2z - comment - 17 Feb 2017

Just reinstalled my testing server - running fine ?

avatar elkuku
elkuku - comment - 17 Feb 2017

The Travis build for PHP nightly is failing. I have no idea why phpcs would
spit out those errors on PHP 7.2 only #confusion ...

Am 17.02.2017 1:56 nachm. schrieb "Dmitry Rekun" notifications@github.com:

Just reinstalled my testing server
http://jtracker.j4devs.ru/tracker/jtracker-tests- running fine ?


You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#945 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AACEujTEHFrTmC1UXdxnhj85fdc7vz4zks5rde1rgaJpZM4L-ls2
.

avatar zero-24
zero-24 - comment - 17 Feb 2017

Where is phpcs failing @elkuku ?

avatar elkuku
elkuku - comment - 17 Feb 2017

@zero-24: It looks like this

avatar zero-24
zero-24 - comment - 17 Feb 2017

please take a look here #948 @elkuku

Add a Comment

Login with GitHub to post a comment