Joomla! Issue Tracker - J!Tracker

Download
Launch
Feeling Lucky

[#92] - Deal with JTable dependency

requirement
avatar mbabker
mbabker
23 Apr 2013

The legacy MVC structure leans heavily on JTable, and that's one package that wasn't carried forward into the Framework. This mainly impacts models and the way the web hooks are implemented right now. Figure out if this is code we want to use, or if not, write the suitable replacement code.

avatar mbabker mbabker - open - 23 Apr 2013
avatar mbabker mbabker - open - 23 Apr 2013
avatar elkuku
elkuku - comment - 25 Apr 2013

I have committed a refactored JTable class: 160e996

The main differences are:

  • Instead of storing the table fields as public member vars, a protected tableFields stdClass var is used, which is accessed by magic __get() and __set() methods.
    There should be no differences in using this class.
  • Methods are chainable.
  • Instead of returning false, exceptions are thrown on failure.
  • All leading underscores have been removed :)
  • No support for assets yet.

Maybe this could work for a while..

avatar mbabker
mbabker - comment - 26 Apr 2013

Looks good to me. I don't know if we'll need the assets support (depends on how we deal with ACL), but we can definitely work with a stripped down JTable and hack away as needed.

avatar - close - 19 Jun 2013
avatar elkuku
elkuku - comment - 19 Jun 2013

Seems like it's working ok.

Add a Comment

Login with GitHub to post a comment