User tests: Successful: Unsuccessful:
Pull Request for Issue #904.
Restructured the issues and pull requests webhook receivers:
opened
, closed
, and reopened
events; we have had funky issues with race conditions when processing other event types as the initial one inserting the dataopened
, closed
, reopened
, edited
, and synchronize
(for pull requests) continue to behave as beforelabeled
and unlabeled
events will now only update the item's labels versus trying to update all datamilestoned
and unmilestoned
, there is no logic for updating milestones implemented into our webhook code at all right now so there's no loss here)The pull request event listener will also now ignore certain actions as these could be problematic; these should only run on full insert/update/edit events.
This also hides synchronize
events from the issue timeline, the same as GitHub natively does.
This should be a little more defensive against changing webhook events. We now have to explicitly code in support for new events versus them automagically being processed, plus this will now limit what some activities do (instead of updating all of the data on every event we only process explicit data for each event type).
All webhook types continue to receive and process data as before.
Status | New | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-11-25 03:11:03 |
Closed_By | ⇒ | mbabker |
@mbabker sorry that was not able to test it :( Was in plans on this weekend, but you were faster :)