Success

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
6 Nov 2016

Pull Request for Issue #904.

Summary of Changes

Restructured the issues and pull requests webhook receivers:

  • When inserting new records, we will only do so for opened, closed, and reopened events; we have had funky issues with race conditions when processing other event types as the initial one inserting the data
  • When updating existing records, there are now different paths based on the action
    • opened, closed, reopened, edited, and synchronize (for pull requests) continue to behave as before
    • labeled and unlabeled events will now only update the item's labels versus trying to update all data
    • Other event types will hit a default case and report as unsupported (this includes milestoned and unmilestoned, there is no logic for updating milestones implemented into our webhook code at all right now so there's no loss here)

The pull request event listener will also now ignore certain actions as these could be problematic; these should only run on full insert/update/edit events.

This also hides synchronize events from the issue timeline, the same as GitHub natively does.

This should be a little more defensive against changing webhook events. We now have to explicitly code in support for new events versus them automagically being processed, plus this will now limit what some activities do (instead of updating all of the data on every event we only process explicit data for each event type).

Testing Instructions

All webhook types continue to receive and process data as before.

avatar mbabker mbabker - open - 6 Nov 2016
avatar mbabker mbabker - reference | 6707d13 - 25 Nov 16
avatar mbabker mbabker - merge - 25 Nov 2016
avatar mbabker mbabker - close - 25 Nov 2016
avatar mbabker mbabker - change - 25 Nov 2016
Status New Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-11-25 03:11:03
Closed_By mbabker
avatar mbabker mbabker - close - 25 Nov 2016
avatar mbabker mbabker - merge - 25 Nov 2016
avatar mbabker mbabker - head_ref_deleted - 25 Nov 2016
avatar b2z
b2z - comment - 25 Nov 2016

@mbabker sorry that was not able to test it :( Was in plans on this weekend, but you were faster :)

Add a Comment

Login with GitHub to post a comment