Labels |
Added:
GitHub sync
|
https://developer.github.com/changes/2016-10-11-pull-request-review-webhooks/
There are now webhooks being pushed out for reviews (API support forthcoming).
API is in preview - https://developer.github.com/changes/2016-12-14-reviews-api/
So as of today we are now storing reviews done in GitHub into the tracker App. How do we want to integrate these into the Joomla workflow? Reviews API is of course now stable - so do we want reviews done in GitHub to show the same as Joomla Tests (i.e. Approvals in GitHub count as tests and good tests are pushed as approvals in GitHub?) or do we want to have GitHub reviews as 'code quality' reviews (which is normally what they are) and as a separate entity to physical tests (what we are doing on the tracker). Opinions?
Only code quality not counting as successful tests
+1
I.e. only physical tests count.
People seem to be using the review as a way of signalling their approval of the concept of the pr. Just like a thumbs up. And nothing more detailed fhan that
Can be an option to use the new "approve" feature instead of RTC ?