GitHub sync
avatar mbabker mbabker - open - 14 Sep 2016
avatar mbabker mbabker - change - 14 Sep 2016
Labels Added: GitHub sync
avatar alikon
alikon - comment - 15 Sep 2016

Can be an option to use the new "approve" feature instead of RTC ?

avatar mbabker
mbabker - comment - 14 Oct 2016

https://developer.github.com/changes/2016-10-11-pull-request-review-webhooks/

There are now webhooks being pushed out for reviews (API support forthcoming).

avatar mbabker
mbabker - comment - 14 Dec 2016
avatar wilsonge
wilsonge - comment - 19 Feb 2018

So as of today we are now storing reviews done in GitHub into the tracker App. How do we want to integrate these into the Joomla workflow? Reviews API is of course now stable - so do we want reviews done in GitHub to show the same as Joomla Tests (i.e. Approvals in GitHub count as tests and good tests are pushed as approvals in GitHub?) or do we want to have GitHub reviews as 'code quality' reviews (which is normally what they are) and as a separate entity to physical tests (what we are doing on the tracker). Opinions?

avatar rdeutz
rdeutz - comment - 19 Feb 2018

Only code quality not counting as successful tests

avatar infograf768
infograf768 - comment - 19 Feb 2018

+1
I.e. only physical tests count.

avatar brianteeman
brianteeman - comment - 19 Feb 2018

People seem to be using the review as a way of signalling their approval of the concept of the pr. Just like a thumbs up. And nothing more detailed fhan that

Add a Comment

Login with GitHub to post a comment