avatar zero-24
zero-24
19 Aug 2016

Steps to reproduce the issue

login with an account that is not allowed to commit or edit the issues. try to do that as member of the JBS Group.

Expected result

state and or description etc. changes. via the bot account

Actual result

403 RuntimeException
Invalid response from GitHub

exception: exception 'JTracker\Github\Exception\GithubException' with message 'Issue not editable by zero-24' in ROOT/src/JTracker/Github/GithubObject.php:49
Stack trace:
#0 ROOT/src/JTracker/Github/Package/Issues.php(155): JTracker\GitHub\GithubObject->processResponse(Object(Joomla\Http\Response))
#1 ROOT/src/App/Tracker/Controller/Issue/Save.php(357): JTracker\Github\Package\Issues->edit('joomla', 'joomla-cms', '11672', 'closed', 'Bundled FOF 2.4...', '### Steps to re...', NULL, NULL, Array)
#2 ROOT/src/App/Tracker/Controller/Issue/Save.php(152): App\Tracker\Controller\Issue\Save->updateGitHub('11672', Array, 'closed', 'open', NULL, NULL, Array)
#3 ROOT/src/JTracker/Application.php(174): App\Tracker\Controller\Issue\Save->execute()
#4 ROOT/vendor/joomla/application/src/AbstractWebApplication.php(134): JTracker\Application->doExecute()
#5 ROOT/www/index.php(103): Joomla\Application\AbstractWebApplication->execute()
#6 {main}

Next exception 'RuntimeException' with message 'Invalid response from GitHub' in ROOT/src/App/Tracker/Controller/Issue/Save.php:173
Stack trace:
#0 ROOT/src/JTracker/Application.php(174): App\Tracker\Controller\Issue\Save->execute()
#1 ROOT/vendor/joomla/application/src/AbstractWebApplication.php(134): JTracker\Application->doExecute()
#2 ROOT/www/index.php(103): Joomla\Application\AbstractWebApplication->execute()
#3 {main}

System information (as much as possible)

Additional comments

avatar zero-24 zero-24 - open - 19 Aug 2016
avatar mbabker
mbabker - comment - 19 Aug 2016

My initial guess, something changed along the way with response codes.

https://github.com/joomla/jissues/blob/master/src/App/Tracker/Controller/Issue/Save.php#L420

avatar zero-24
zero-24 - comment - 19 Aug 2016

hmm looks like they moved it to 403? Maybe we double check for 404 & 403?

avatar zero-24
zero-24 - comment - 20 Aug 2016

hmm looks like now we have the wrong commenter.

see: joomla/joomla-cms#11682 (comment)

I would expect the this comment is done by @joomla-cms-bot

avatar zero-24
zero-24 - comment - 21 Aug 2016

Works now thanks @mbabker

avatar zero-24 zero-24 - change - 21 Aug 2016
Status New Closed
Closed_Date 0000-00-00 00:00:00 2016-08-21 15:15:52
Closed_By zero-24
avatar zero-24 zero-24 - close - 21 Aug 2016

Add a Comment

Login with GitHub to post a comment