Joomla! Issue Tracker - J!Tracker

Download
Launch
Feeling Lucky

[#845] - Add auto category feature for the JavaScript category

Success

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
22 Jul 2016

Summary of Changes

Add auto category for JS changes

Testing Instructions

Change a JS file (.js) => the JavaScript category should be added by the Tracker ?

avatar zero-24 zero-24 - open - 22 Jul 2016
avatar brianteeman
brianteeman - comment - 22 Jul 2016

Thanks for adding this

avatar elkuku elkuku - change - 22 Jul 2016
Status New ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-07-22 14:12:54
Closed_By ⇒ elkuku
avatar elkuku elkuku - close - 22 Jul 2016
avatar elkuku elkuku - merge - 22 Jul 2016
avatar elkuku elkuku - reference | 9c9b8df - 22 Jul 16
avatar elkuku elkuku - merge - 22 Jul 2016
avatar elkuku elkuku - close - 22 Jul 2016
avatar elkuku
elkuku - comment - 22 Jul 2016

Looks good on code review ;)

Just a small note...
If it happens that foobar.js.php exists for some reason and is treated as a js file, you might finally switch to regular expressions ?

avatar elkuku
elkuku - comment - 22 Jul 2016

ARGH, and looking over it again I noticed, that

strpos($file->filename, '.js') === 0

will check if the file name starts with .js

So the whole thing won't work :(

You might just write 

if (preg_match('/.js$/', $file))

To check that the file ends ($) with .js

avatar elkuku elkuku - reference | a159795 - 22 Jul 16
avatar elkuku
elkuku - comment - 22 Jul 2016

OK I just modified that, maybe toy could take a look at a159795 to see if that's OK?

avatar zero-24
zero-24 - comment - 22 Jul 2016

Ahh sorry @elkuku just a c&p error. Thanks.

avatar zero-24 zero-24 - head_ref_deleted - 22 Jul 2016
avatar elkuku
elkuku - comment - 22 Jul 2016

c&p is so evil...

Add a Comment

Login with GitHub to post a comment