Joomla! Issue Tracker | J!Tracker #843

Fixed in Code Base
22 Jul 2016
Medium
Build: master
# 843
Diff
joomla:cli-check-args

Success

Success continuous-integration/travis-ci/push The Travis CI build passed Details
Success continuous-integration/travis-ci/pr The Travis CI build passed Details

User tests: Successful: Unsuccessful:

elkuku
21 Jul 2016

This will add validation for arguments passed on the command line.

Validation for `command` arguments

Assures that there are no duplicates. If a duplicate is found a message similar to the following is generated:

ERROR: The command "Application\Command\Database\Migrate" tried to add option "v" already defined in the application.

The method TrackerCommand::getOption() has been added to validate and fetch command line arguments from the input. Required code changes:

// Before:
$option = $this->getApplication()->input->get('longName', $this->getApplication()->input->get('shortName'));

// After:
$option = $this->getOption('longName');

This will look for both long and short name.

Validation for unsupported arguments passed from user input.

e.g.
$ jtracker --foo
will result in
ERROR: The argument "foo" is not recognized.

Testing instructions

Check that all CLI commands execute successfully
Check that cron jobs using parameters still run...
Short option -v has been removed from commands database migrate and update server.
Use --version instead.