[#823] - Use OAuth client for authentication, build authorization URL via GitHub API object
- Fixed in Code Base
- 18 Jul 2016
- Medium
- Build: master
- # 823
- Diff
- joomla:use-oauth-client
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Error continuous-integration/travis-ci/push The Travis CI build could not complete due to an error Details
User tests: Successful: Unsuccessful:
I didn't look why this code wasn't working before, but it seems to work fine for me locally so let's use it (seems to be the intent previously?).
Also use the GitHub API objects to build the authorization URL instead of our inline code.
Good question?
On Monday, July 18, 2016, Nikolai Plath notifications@github.com wrote:
After scratching my head for a while I remembered that I did that because
of the following scenario:
We have a second "login" button next to the comment box on the issue view.
I remember that the anchor parameter (#) got lost using J OAuth so after
a successfull login you would have to scroll down to the comment box
again...Does that still happen? is it a problem??
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#823 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAWfoTl_Ap0E_MJU_d0JETAoAnApXR9Rks5qW3ZWgaJpZM4JItJP
.
| Status | New | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-07-18 13:13:01 |
| Closed_By | ⇒ | elkuku |
Anchor links are still eaten up :(
Darn
On Monday, July 18, 2016, Nikolai Plath notifications@github.com wrote:
Anchor links are still eaten up :(
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#823 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAWfocVoRKZB3BfbDTuLgeHZ3CKX4UXxks5qW3wPgaJpZM4JItJP
.
So the anchor probably gets lost because the redirect is based on $application->get('uri.request') and I don't think the Uri class will have that anchor attached unless you requested the page with the anchor to begin with.
Funny, I was looking at the code thinking the same thing....
I swear that it was working at some point :P
After scratching my head for a while I remembered that I did that because of the following scenario:
We have a second "login" button next to the comment box on the issue view.
I remember that the anchor parameter (
#) got lost using J OAuth so after a successfull login you would have to scroll down to the comment box again...Does that still happen? is it a problem??