Feeling Lucky
[#812] - Stop sending 'PR has new commits' comment
- Fixed in Code Base
- 15 Jul 2016
- Medium
- Build: master
- # 812
- Diff
- joomla:no-more-commit-comments
- Failure continuous-integration/travis-ci/pr The Travis CI build failed Details
- Failure continuous-integration/travis-ci/push The Travis CI build failed Details
User tests: Successful: Unsuccessful:
GitHub has started sending email notifications for commit activity on pull requests. IMO it kinda invalidates our need for the bot to comment on PRs in this state, so this PR removes that functionality.
Thoughts?
mbabker
- comment
- 2 Jul 2016
You have to already be subscribed to an issue for it to work. So their notifications are targeted more specifically whereas the comment notification goes to everyone.
mbabker
- comment
- 2 Jul 2016
Example:
zero-24
- comment
- 3 Jul 2016
zero-24
- comment
- 14 Jul 2016
Is there any reason to not merge This?
b2z
- comment
- 15 Jul 2016
Code review ok, but This branch has conflicts that must be resolved
zero-24
- comment
- 15 Jul 2016
And now we have travis errors ;)
FILE: /home/travis/build/joomla/jissues/cli/tracker.php
--------------------------------------------------------------------------------
FOUND 0 ERROR(S) AND 1 WARNING(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
119 | WARNING | Line exceeds 150 characters; contains 151 characters
--------------------------------------------------------------------------------
UPGRADE TO PHP_CODESNIFFER 2.0 TO FIX ERRORS AUTOMATICALLY
--------------------------------------------------------------------------------
mbabker
- comment
- 15 Jul 2016
Exists in master, not unique here.
| Status | New | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-07-15 14:02:01 |
| Closed_By | ⇒ | b2z |
Hmm. I have not noticed that behavior? But if github will do this I agree with you.