Success

User tests: Successful: Unsuccessful:

avatar elkuku
elkuku
23 Jun 2016

Fix #806

Bug: The users language parameter (if set) overrides the session language parameter (if set) causing the current language to be "resetted" to the users parameter language.

This happens if the following criteria are met:

  1. You are logged in.
  2. You have set a language in you user settings (in jissues)
  3. This language is different from the one you are selecting using the language selector.

Summary of Changes

The Application class now has a method to get the current language tag.

Now the language code present in the session (if so) is preferred over the user parameter. I guess that this should be the right behaviour.

Note: While I completely dislike adding even more code to the Application class, I swear that I will move the loadLanguage() method to the LanguageHelper class "soonish" ?

Testing Instructions

Check that the erroneous behaviour described in #806 is fixed.

@b2z would you mind checking that nothing broke with the user param please?

avatar elkuku elkuku - open - 23 Jun 2016
avatar elkuku elkuku - change - 23 Jun 2016
The description was changed
avatar elkuku elkuku - change - 23 Jun 2016
The description was changed
avatar b2z
b2z - comment - 25 Jun 2016

Tested ?

avatar b2z b2z - change - 25 Jun 2016
Status New Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-06-25 05:04:40
Closed_By b2z
avatar b2z b2z - close - 25 Jun 2016
avatar b2z b2z - merge - 25 Jun 2016

Add a Comment

Login with GitHub to post a comment