[#798] - Use Framework v2 Renderer & View, Upgrade Whoops
- Fixed in Code Base
- 19 Jun 2016
- Medium
- Build: master
- # 798
- Diff
- joomla:FW-renderer
- Success continuous-integration/travis-ci/push The Travis CI build passed Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Summary of Changes
Converts the view/rendering API to use the Framework v2 renderer and view packages and upgrades the filp/whoops package to the current version. Converts the renderer configuration logic to a service provider and moved out of the base controller.
Testing Instructions
Double check everything still renders as expected.
What Doesn't Work Anymore?
The pure PHP renderer doesn't work anymore. Considering those templates are long abandoned I don't see the issue with that. Mustache and Twig integrations should still be fine.
| Status | New | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-06-19 15:38:28 |
| Closed_By | ⇒ | elkuku |
The pure PHP renderer doesn't work anymore.
No issue with that
because of a "3pd" silently requiring the
joomla/filesystempackage that has been removed by this PR
This is why you declare your dependencies
I tried to triple check and everything still seems to render as it should.
One small exception: The clean cache command does not work anymore because of a "3pd" silently requiring the?
joomla/filesystempackage that has been removed by this PR.Updating the
elkuku/g11npackage will solve this issueSince it removes > 1k lines of code I can't resist to push that merge button?