Success

User tests: Successful: Unsuccessful:

avatar elkuku
elkuku
14 Jun 2016

Pull Request for Issue #787

This is an alternative to #795 with less code added ?

Summary of Changes

  • Methods have been added to allow file exchange with https://crowdin.com
  • The library elkuku/crowdin-api has been added to the composer file.
  • Properties for crowdin credentials have been added to /etc/config.dist.json

Testing Instructions

Upload new language templates

jtracker update languagefiles --provider=crowdin --create

Upload already existing translated files to crowdin

jtracker update languagefiles --provider=crowdin --translations

This should only run once.

Download translated files

jtracker get languagefiles --provider=crowdin

Hint: I very personally would prefer this one over #795 ?

fix #787 close #795

avatar elkuku elkuku - open - 14 Jun 2016
avatar elkuku
elkuku - comment - 14 Jun 2016

Note that methods have been consolidated in a B/C braking way now...

A provider parameter is now required to execute the commands. E.g.

jtracker update languagefiles --provider=transifex

Test instructions have been updated.

avatar mbabker
mbabker - comment - 18 Jun 2016

Note that methods have been consolidated in a B/C braking way now...

Well, glad we never tagged a "stable" version ?

I'd say sync this with master to make sure the service stuff didn't screw anything up and this should be good to go.

avatar elkuku
elkuku - comment - 18 Jun 2016

Synced.

avatar elkuku elkuku - change - 18 Jun 2016
The description was changed
avatar elkuku elkuku - change - 18 Jun 2016
The description was changed
avatar mbabker
mbabker - comment - 19 Jun 2016

Seems like it works (did a test fetch from Transifex with this branch and it pulled files correctly).

avatar mbabker mbabker - change - 19 Jun 2016
Status New Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-06-19 16:37:00
Closed_By mbabker
avatar mbabker mbabker - close - 19 Jun 2016
avatar mbabker mbabker - merge - 19 Jun 2016
avatar mbabker mbabker - reference | b248425 - 19 Jun 16
avatar mbabker mbabker - merge - 19 Jun 2016
avatar mbabker mbabker - close - 19 Jun 2016
avatar mbabker mbabker - head_ref_deleted - 19 Jun 2016
avatar elkuku
elkuku - comment - 19 Jun 2016

did a test fetch from Transifex

Nice test... ?

avatar mbabker
mbabker - comment - 19 Jun 2016

I went with what I had available, which made sure all the application relative code worked right. I hope your package is tested and works ?

avatar elkuku
elkuku - comment - 19 Jun 2016

I hope your package is tested

Well it has 100% unit test coverage... but since the only "real" tests are in the real world, the jissues project would have the honour to report the first issue then :)

avatar elkuku
elkuku - comment - 19 Jun 2016

Hmm @mbabker so you are using the new squash/merge feature GitHub offers?
I'd like to say that I don't think it's a good thing. One of the features I love about git is the "commit often" policy...

avatar mbabker
mbabker - comment - 19 Jun 2016

Actually I just hit the button twice and didn't realize it squashed it until too late.

avatar mbabker
mbabker - comment - 19 Jun 2016

I turned off the squash merge option. I didn't realize that GitHub was defaulting to this now. Guess I should RTFI once in a while.

avatar elkuku
elkuku - comment - 19 Jun 2016

Al good - stuff happens ?

Add a Comment

Login with GitHub to post a comment