[#755] - Log Exceptions per PSR-3 standard
- Fixed in Code Base
- 12 Mar 2016
- Medium
- Build: master
- # 755
- Diff
- joomla:Exception-Logging
- Success continuous-integration/travis-ci/push The Travis CI build passed Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Summary of Changes
PSR-3 defines a standard for how Exceptions should be logged by attaching it to the context array of a log message. Monolog supports this structure. So, all places where Exceptions are being logged now attach the Exception to the context array (in the case of Monolog, the full Exception's data (type, message, code, and trace) get attached to log messages which actually makes these a bit more useful now.
Also changed a couple of places to chain Exceptions where there was a new Exception being thrown.
Testing Instructions
Trigger an error, validate Exception data is logged. Or read the code and make sure I didn't screw this up.
| Status | New | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-03-12 18:20:20 |
| Closed_By | ⇒ | b2z |
For reference, glance at the last couple entries in https://issues.joomla.org/logs/error and that'll show how something was logged without the exception context and with it.
Ok I've reviewed the code and do not see any issues. Will merge and lets see. Testing this would be a tough task to do...