I think so. Should we support other file extensions like pdf, docx etc?
https://github.com/blog/2061-attach-files-to-comments

It depends how you wanna render them. pdf.js is Apache license which is only compatible with GPLv3 for example... :(

That's not necessarily a problem as long as it is used on jissues and not
in the cms itself
On 18 Feb 2016 9:21 am, "George Wilson" notifications@github.com wrote:

It depends how you wanna render them. pdf.js is only GPLv3 and higher for
example... :(

—
Reply to this email directly or view it on GitHub
#744 (comment).

Edited comment above for clarity - although I think Brian's point still stands...

We don't have to support rendering them though. Just use "normal" browser behaviors for text file types like that (link it and let the user/browser decide to open in browser, download file, etc.). With images there's an expectation to render them inline, files not so much.

Fine. Although doing some kind of export treatment for the Joomla server info would be nice - so people can see it as part of the issue 'automagically'

If you really wanted to inline the data you could tell people to upload the JSON file and our code could read that and spit out "human friendly" text. But honestly I don't see it being mandatory to do that as long as the data gets uploaded/attached to an issue in any form.

I don't think it should be mandatory. But it be an option.... I think there's a decent number of bug reports where users don't know what server info to upload

To an extent, I agree. But ultimately, the tracker's comment fields shouldn't be doing too much beyond what GitHub offers (all our extra functionality is around features GitHub doesn't have). This borderline crosses into "we're doing something that the user cannot do on GitHub" if we start manipulating comment text based on file uploads matching certain criteria. Support file uploads the same way GitHub does, +1 all day every day. Magically take a JSON or TXT file exported from Joomla, uploaded through the regular file processor, and spit it into the user's input field? I wouldn't encourage it.

Def more useful for the forum than for the tracker
On 18 Feb 2016 6:35 pm, "Michael Babker" notifications@github.com wrote:

To an extent, I agree. But ultimately, the tracker's comment fields
shouldn't be doing too much beyond what GitHub offers (all our extra
functionality is around features GitHub doesn't have). This borderline
crosses into "we're doing something that the user cannot do on GitHub" if
we start manipulating comment text based on file uploads matching certain
criteria. Support file uploads the same way GitHub does, +1 all day every
day. Magically take a JSON or TXT file exported from Joomla, uploaded
through the regular file processor, and spit it into the user's input
field? I wouldn't encourage it.

—
Reply to this email directly or view it on GitHub
#744 (comment).

Please test #747