Pending

User tests: Successful: Unsuccessful:

avatar davidhurley
davidhurley
9 Jan 2013

I had done this previously but apparently in the merging of old branches this got missed.

https://github.com/JTracker/jissues/commit/8e3b831e7313dd2457eca27733ccd2a960625659

avatar davidhurley davidhurley - open - 9 Jan 2013
avatar davidhurley davidhurley - open - 9 Jan 2013
avatar elkuku
elkuku - comment - 10 Jan 2013

I am not sure what's happening here..
As far as I can see the description field is already present for the #__categories table.
See: https://github.com/JTracker/jissues/blob/master/sql/mysql.sql#L142

Are you sure that your branch is up to date ? What's going on here ¿

avatar mbabker mbabker - close - 1 Feb 2013
avatar mbabker
mbabker - comment - 1 Feb 2013

The field is in the master branch now as highlighted. Looking at the actual pull a bit more, it looks like it's based off an older commit because of where the line change is made. Even more odd is that I don't see a sql-problem branch on David's repo right now, and usually GitHub's pretty good about closing PR's when branches disappear.

avatar - close - 1 Feb 2013
avatar davidhurley
davidhurley - comment - 1 Feb 2013

It was missing for some reason, but then I pulled a later copy and it had been committed again. I deleted the branch assuming GitHub would close the PR.

Add a Comment

Login with GitHub to post a comment