enhancement Pending

User tests: Successful: Unsuccessful:

avatar jasonwilliams
jasonwilliams
8 Jan 2013

Add username to Modified so users can see who last made a comment or edited a ticket without having to open the ticket up.

avatar Jayflux Jayflux - open - 8 Jan 2013
avatar Jayflux Jayflux - open - 8 Jan 2013
avatar Jayflux
Jayflux - comment - 8 Jan 2013

Sorry, i forgot pull requests also generate issues, so now I have 2 here!

Anyway to inclue what I said before:

Whenever I look at the current tracker, one of the first things I wish to know is who last looked at it/made a change.
Instead of just a date could we have something like:

Last Modified 2013-01-01
by Jayflux

You would then be able to see who looked/modified the issue without having to even open it up

I have included a commit which does this.

avatar mbabker
mbabker - comment - 8 Jan 2013

Normally, setting the modified_by field is handled in the table class, not the controller. So, this would be better suited for JTableIssue::store() IMO. You can check how it is done in JTableContent to get an idea. Other than that nitpick, I don't see a problem with this.

avatar elkuku elkuku - reference | - 11 Jan 13
avatar Jayflux
Jayflux - comment - 14 Jan 2013

mbaker ^^ Is that what you meant?

avatar drmmr763
drmmr763 - comment - 14 Jan 2013

I believe he meant from here
https://github.com/JTracker/jissues/blob/master/libraries/tracker/table/issue.php

On Sunday, January 13, 2013, Jayflux wrote:

mbaker ^^ Is that what you meant?


Reply to this email directly or view it on GitHubhttps://github.com/JTracker/jissues/pull/72#issuecomment-12203988.

Regards,
Chad Windnagle
Fight SOPA https://www.google.com/landing/takeaction/

avatar drmmr763
drmmr763 - comment - 15 Jan 2013

@elkuku I believe that's just the column for it in the database. I believe that @Jayflux's code updates that column on save.

@Jayflux this can't be automatically merged. Can you update your PR ?

avatar elkuku
elkuku - comment - 15 Jan 2013

What I meant is that the id is an integer not a varchar, but it should work anyway ;)

avatar Jayflux
Jayflux - comment - 16 Jan 2013

Done...

avatar elkuku elkuku - reference | - 21 Jan 13
avatar elkuku elkuku - merge - 21 Jan 2013
avatar elkuku elkuku - close - 21 Jan 2013
avatar - close - 21 Jan 2013
avatar elkuku
elkuku - comment - 21 Jan 2013

I think we should merge this before it gets outdated :wink:

avatar elkuku elkuku - reference | - 24 Apr 13

Add a Comment

Login with GitHub to post a comment