Success

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
5 Oct 2015

Some days bevor i was thinking PLT acion is admin but since i'm in the same Group as the other PLT Memebers i notice the they have the action manage and the admin is something more higher. ;)

But i guess we can allow the using of labels and milestones to the PLT and me as well until they don't decide different. :)

avatar zero-24 zero-24 - open - 5 Oct 2015
avatar b2z
b2z - comment - 14 Oct 2015

Code looks correct. Can someone from PLT confirm? :)

avatar Bakual
Bakual - comment - 14 Oct 2015

Go ahead. I don't see any issues with that :)

avatar b2z
b2z - comment - 15 Oct 2015

ok :) But need to test one thing - will admins loose their access or not. Possibly the code should check both for manage and admin.

avatar Bakual
Bakual - comment - 15 Oct 2015

Dunno how the ACL in JIssues works, but I would expect that the higher rank "admin" would inherit "manage", or that PLT is at least able to "manage" when they are set up as "admin" :)

But we can just try it after you commited. It's not like it will be a fatal error :smile:

avatar b2z
b2z - comment - 15 Oct 2015

Just explored our ACL - no inheritance there as I can see.

But yes, we can commit as it is - not a big deal :tongue:

avatar zero-24
zero-24 - comment - 15 Oct 2015

@b2z see: https://github.com/joomla/jissues/blob/master/src/JTracker/Authentication/User.php#L305

// "Admin users" are granted all permissions - globally.

avatar b2z
b2z - comment - 15 Oct 2015

Of course - gods of JTracker :smile: :tongue: Merged :wink:

avatar b2z b2z - change - 15 Oct 2015
Status New Closed
Closed_Date 0000-00-00 00:00:00 2015-10-15 09:01:28
Closed_By b2z
avatar b2z b2z - close - 15 Oct 2015
avatar b2z b2z - reference | ae3bc7f - 15 Oct 15
avatar b2z b2z - merge - 15 Oct 2015
avatar b2z b2z - close - 15 Oct 2015
avatar zero-24 zero-24 - head_ref_deleted - 15 Oct 2015

Add a Comment

Login with GitHub to post a comment