Feeling Lucky
enhancement
[#684] - Return a response with appropriate error code on errors. REF: #681
- Closed
- 25 Nov 2016
- Medium
- Build: master
- # 684
- Diff
- wilsonge:hooks
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
| Labels |
Added:
enhancement
|
||
mbabker
- comment
- 25 Nov 2016
Outdated. Webhook handlers have been updated a bunch since this PR.
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-11-25 03:35:40 |
| Closed_By | ⇒ | mbabker |
I just discovered that, depending on the servers error reporting settings, the application does in fact provide some kind of errm... error response.
E.g. for the initial "ping" event that is sent from GitHub, one might get a
Obviously this goes with a
200status code...I think we should improve our error reporting. We are relying 100% on valid data received from GitHub.
Can we redo this PR without altering the workflow?