Feeling Lucky
[#677] - Fix some possible setup errors
- Closed
- 8 Jul 2015
- Medium
- Build: master
- # 677
- Diff
- joomla:install-errors
- Success continuous-integration/travis-ci/push The Travis CI build passed Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Hello again
I recently had to setup my environment on a new computer and I ran into some installation problems, so this PR tries to fix this for new installs (exising install should not be affected so this should be full B/C
- php-curl is not installed
In this caseHttpFactory::getAvailableDriver()returnsfalse. We miss a check in ourGitHubLoginHelperhere so the next call will produce a fatal error.
I also added the CURL extension as a dependency to ourcomposer.jsonfile so the application wouldn't even install if CURL is not available. - The log path is not available
This might have changed in recent Apache versions, not sure. It is required to use a full path in the config file for the log path setting as a relative path would not work (at least on my system).
Please review.
mbabker
- | Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-07-08 16:34:03 |
| Closed_By | ⇒ | mbabker |