GitHub sync bug
avatar zero-24
zero-24
18 May 2015

Since the fix here: #656 by @b2z it looks better but now we have a reversed behavior.

The milestone gets removed on github (and it looks i don't get synced):
http://issues.joomla.org/tracker/joomla-cms/6966
joomla/joomla-cms#6966

George added the milestone.
Moving to RTC
Peter added a commit
The bot adds the RTC label
and remove the milestone ?

see:
milestone_again
milestone_again_tracker

avatar zero-24 zero-24 - open - 18 May 2015
avatar b2z
b2z - comment - 18 May 2015

Nasty bot :(

What bothers me is that the milestone is not synced back. I am testing it now here:
http://jissues.j4devs.ru/tracker/jissues-test/2
b2z/jissues-test#2

You can see that it is synced. I have a cron job running there once per hour, lets see in the next hour will it sync back the removal of the milestone.

P.S.
Still labels are duplicating after the cron job. But that's the next task for me in #655

avatar b2z b2z - change - 18 May 2015
Labels Added: bug GitHub sync
avatar b2z b2z - change - 18 May 2015
Labels Added: bug
avatar b2z b2z - change - 18 May 2015
Labels Added: GitHub sync
avatar b2z b2z - assigned - 18 May 15
avatar b2z
b2z - comment - 18 May 2015

Well as you can see here all is synced :confused:

@zero-24 can you make a test in the CMS repo - add milestone/remove milestone?
For example here:
joomla/joomla-cms#6859 (Issue)
and here:
joomla/joomla-cms#6968 (Pull request)

Thanks :)

avatar zero-24
zero-24 - comment - 18 May 2015

@b2z just added for testing the 4.0 milestone. (using github)

avatar b2z
b2z - comment - 18 May 2015

Yeah thanks. Now we will wait and see what will happen :smile:

avatar b2z
b2z - comment - 18 May 2015

Well - nothing :disappointed:

@mbabker is there any problem with the cron job? Also how do you think why nasty joomla-cms-bot removed the milestone?

avatar mbabker
mbabker - comment - 18 May 2015

Crons might be hitting limits again or something. The log file shows a couple of the repos not finishing. I might need to start writing the raw output from the jobs to the filesystem again.

avatar mbabker
mbabker - comment - 18 May 2015

And in general the crons shouldn't be removing the milestones unless this line has a bug in its logic.

avatar b2z
b2z - comment - 18 May 2015

And in general the crons shouldn't be removing the milestones unless this line has a bug in its logic.

Crons should be fine, I've tested several times (see my tests above).

avatar b2z
b2z - comment - 18 May 2015

Crons might be hitting limits again or something.

I think we should increase time between them for some projects. For example for JTracker or JTests we might run it every 2 hours or something.

avatar mbabker
mbabker - comment - 18 May 2015

The time won't matter if it's hitting the rate limits. It'll just cause one hour to not be limited and another will. If it's another error, catching the output for the cron jobs will help figure out what to do.

avatar b2z
b2z - comment - 20 May 2015

@mbabker I hope you will fix it ;)

@zero-24 I think you can remove this testing milestone till the cron job will be fixed.

avatar zero-24
zero-24 - comment - 20 May 2015

@zero-24 I think you can remove this testing milestone till the cron job will be fixed.

Done :smile:

avatar b2z
b2z - comment - 15 Jun 2015

So @zero-24 we can test again now. I think it should be fixed.

avatar zero-24
zero-24 - comment - 15 Jun 2015

Ok lets try :smile: I have add the 3.4.0 milestone again to

joomla/joomla-cms#6859
and
joomla/joomla-cms#6968

avatar b2z
b2z - comment - 16 Jun 2015

Still nothing... :confused:

avatar b2z
b2z - comment - 3 Jul 2015

@mbabker can you look into it please? I have milestones synced normally on my test server. See this for example. But on the CMS tracker they are not synced. @zero-24 right?

avatar zero-24 zero-24 - change - 17 Oct 2015
Status New Closed
Closed_Date 0000-00-00 00:00:00 2015-10-17 22:50:14
Closed_By zero-24
avatar zero-24 zero-24 - close - 17 Oct 2015

Add a Comment

Login with GitHub to post a comment