Joomla! Issue Tracker - J!Tracker

Download
Launch
Feeling Lucky

[#650] - Change the link to the diff

avatar roland-d
roland-d
3 May 2015

Steps to reproduce the issue

Open an issue which has code attached and look at the link for the diff, it is shown as:
https://github.com/joomla/joomla-cms/pull/3108.diff however this URL redirects to https://patch-diff.githubusercontent.com/raw/joomla/joomla-cms/pull/3108.diff. For CLI use, the latter URL is usable and the former is not. The former gives the following error:
fatal: unrecognized input

when doing curl https://github.com/joomla/joomla-cms/pull/3079.diff | git apply

Expected result

Get the real URL to the diff.

Actual result

Currently it shows the nice URL rather than the real url.

System information (as much as possible)

Windows 8.1
FireFox 37.0.2

Additional comments

avatar roland-d roland-d - open - 3 May 2015
avatar mbabker
mbabker - comment - 3 May 2015

That must be a recent change in GitHub because the first URL used to work just fine.

avatar mbabker mbabker - change - 3 May 2015
Status New ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-05-03 14:39:42
Closed_By ⇒ mbabker
avatar mbabker mbabker - close - 3 May 2015
avatar mbabker mbabker - close - 3 May 2015
avatar roland-d
roland-d - comment - 3 May 2015

@mbabker I agree, I also think it is a recent change because it used to work in the past. Thanks for the fix.

Add a Comment

Login with GitHub to post a comment